Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Use document owner for matching if set #3198

Merged
merged 1 commit into from Apr 26, 2023
Merged

Fix: Use document owner for matching if set #3198

merged 1 commit into from Apr 26, 2023

Conversation

shamoon
Copy link
Member

@shamoon shamoon commented Apr 26, 2023

Proposed change

Owner was only being used for suggestions. If its set on the document we can just use that to filter objects.

Fixes #3196

With change:
Screenshot 2023-04-26 at 9 29 00 AM

Before:
Screenshot 2023-04-26 at 9 40 03 AM

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other (please explain)

Checklist:

  • I have read & agree with the contributing guidelines.
  • If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.
  • If applicable, I have checked that all tests pass, see documentation.
  • I have run all pre-commit hooks, see documentation.
  • I have made corresponding changes to the documentation as needed.
  • I have checked my modifications for any breaking changes.

@shamoon shamoon requested a review from a team as a code owner April 26, 2023 16:40
@github-actions github-actions bot added the bug Bug report or a Bug-fix label Apr 26, 2023
@codecov
Copy link

codecov bot commented Apr 26, 2023

Codecov Report

Merging #3198 (5ae48c8) into dev (6f16311) will decrease coverage by 0.06%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##              dev    #3198      +/-   ##
==========================================
- Coverage   93.37%   93.32%   -0.06%     
==========================================
  Files         156      156              
  Lines        6609     6617       +8     
==========================================
+ Hits         6171     6175       +4     
- Misses        438      442       +4     
Flag Coverage Δ
backend 93.32% <50.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/documents/matching.py 91.83% <50.00%> (-3.72%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@shamoon shamoon merged commit be88ad2 into dev Apr 26, 2023
29 checks passed
@shamoon shamoon deleted the fix/issue-3196 branch April 26, 2023 17:46
@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backend bug Bug report or a Bug-fix small-change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Tags user has no permissions for show as "Private" after file upload
2 participants