Fix: advanced search or date searching + doc type/correspondent/storage path broken

[shamoon]

Proposed change

This is because of #2893 because the new query vars are object__id__in and object__id__none which weren't included in the list when using whoosh searches (e.g. date or advanced search)

Fixes #3206

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Other (please explain)

Checklist:

• I have read & agree with the contributing guidelines.
• If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.
• If applicable, I have checked that all tests pass, see documentation.
• I have run all pre-commit hooks, see documentation.
• I have made corresponding changes to the documentation as needed.
• I have checked my modifications for any breaking changes.

[codecov]

Codecov Report

Merging #3209 (1a1cf49) into dev (d3e1481) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              dev    #3209      +/-   ##
==========================================
+ Coverage   93.32%   93.34%   +0.01%     
==========================================
  Files         156      156              
  Lines        6638     6656      +18     
==========================================
+ Hits         6195     6213      +18     
  Misses        443      443              

Flag	Coverage Δ
backend	93.34% <100.00%> (+0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
src/documents/index.py	94.35% <100.00%> (+0.57%)	⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[Skram-de]

Thank you for merging & publishing that fast.
But the fix isn't working in V1.14.2 (after reindexing), please re-open.

"added last year" selected leads to an empty result set this time:

[shamoon]

Hmm, make sure you re-create your container (not restart), etc. does seem to work for me:

I also added tests for this so I do think its fixed, but let us know...

[Skram-de]

I recreated the container before.

Behaviour changed from "ignoring document type" as in #3206 to "empty result set" in V1.14.2. (see above)

• Combination of "document type" & "storage path" works.
• Combination of "document type" & "after date" works.

"Last year" without any second parameter also works fine.

[Skram-de]

@shamoon , apply an owner to the documents!
Docs without an owner are shown.
Docs with owner set will hide. That's what leads to an empty result set with my data.

[shamoon]

Hmm, still cant reproduce on my end, sample-50-MB-pdf-file here has an owner

[shamoon]

I see the issue, a document you dont own but have view permissions on

It's kind of related but not the same issue, believe it or not. Tracking in #3221

[Skram-de]

yeah, that's it, can reproduce!
=> document I dont own but have view permissions on

[Skram-de]

Even if my bug description was a bit of nitpicking:
Adding multi-user-permissions to this project was really, really great work!

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns.