Fix: ALLOWED_HOSTS logic being overwritten when * is set

[ikaruswill]

Proposed change

1. If ALLOWED_HOSTS = ["*"], do nothing
2. If ALLOWED_HOSTS != ["*"] append localhost
3. If ALLOWED_HOSTS != ["*"] and PAPERLESS_URL is defined, append localhost and _paperless_uri.hostname

Fixes #3214

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Other (please explain)

Checklist:

• I have read & agree with the contributing guidelines.
• If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.
• If applicable, I have checked that all tests pass, see documentation.
• I have run all pre-commit hooks, see documentation.
• I have made corresponding changes to the documentation as needed.
• I have checked my modifications for any breaking changes.

[shamoon]

This makes sense to me, thanks

[codecov]

Codecov Report

Merging #3218 (83344f7) into dev (daaeb36) will increase coverage by 0.00%.
The diff coverage is 33.33%.

@@           Coverage Diff           @@
##              dev    #3218   +/-   ##
=======================================
  Coverage   93.34%   93.34%           
=======================================
  Files         156      156           
  Lines        6656     6657    +1     
=======================================
+ Hits         6213     6214    +1     
  Misses        443      443           

Flag	Coverage Δ
backend	93.34% <33.33%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
src/paperless/settings.py	85.55% <33.33%> (+0.05%)	⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[stumpylog]

Seems good to me as well. We can ignore the patch coverage failure. settings isn't covered for this sort of setup

[ikaruswill]

Sorry spotted something hang on.

[ikaruswill]

Sorry folks it's 3:24AM here, I guess coding at night isn't a great idea.

Before:

ALLOWED_HOSTS.append(["localhost"])

I was appending a list to a list. But it should be appending a host as a string to the list.

ALLOWED_HOSTS.append("localhost")

[shamoon]

Appreciate you catching that syntax thing!

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns.