Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: better keyboard nav for filter/edit dropdowns #3227

Merged
merged 1 commit into from Apr 29, 2023

Conversation

shamoon
Copy link
Member

@shamoon shamoon commented Apr 28, 2023

Proposed change

Small QoL thing, this PR adds up / down arrow key support to the filter / edit dropdowns (tab, enter / space already work). It's a little more code than I thought because it works with click / tab (e.g. clicking or using tab doesn't break the up / down). For the filtering field if you hit down when cursor is at the last character it will go down the list. This feels really natural when using imho.

dropdownkeyboard.mov

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other (please explain)

Checklist:

  • I have read & agree with the contributing guidelines.
  • If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.
  • If applicable, I have checked that all tests pass, see documentation.
  • I have run all pre-commit hooks, see documentation.
  • I have made corresponding changes to the documentation as needed.
  • I have checked my modifications for any breaking changes.

@shamoon shamoon requested a review from a team as a code owner April 28, 2023 06:55
@paperless-ngx-secretary paperless-ngx-secretary bot added frontend non-trivial Requires approval by several team members labels Apr 28, 2023
@github-actions github-actions bot added the enhancement New feature label Apr 28, 2023
Copy link
Member

@stumpylog stumpylog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll have to assume this is all correct

@shamoon shamoon merged commit a8e1240 into dev Apr 29, 2023
31 checks passed
@shamoon shamoon deleted the feature/better-keyboard-dropdowns branch April 29, 2023 03:51
@shamoon shamoon added this to the v1.14.3 milestone Apr 29, 2023
@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature frontend non-trivial Requires approval by several team members
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants