Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Rework workflows #3242

Merged
merged 4 commits into from May 5, 2023
Merged

Chore: Rework workflows #3242

merged 4 commits into from May 5, 2023

Conversation

stumpylog
Copy link
Member

@stumpylog stumpylog commented Apr 28, 2023

Proposed change

Now that the actual image is decoupled from the build installers (thanks to the downloaded archive instead of being pulled from images), building the installers in another repo is a viable solution again. So this revives the old builder repo to build wheels and .deb on a manual dispatch. That should only need to happen every so often. Even less with dependabot being so broke...

  • Pulls the installer archive from another repo, removing a bunch of binary files from this repo
  • Removes a bunch of code from here
  • I packaged our cleaner into an action (and used it in immich!), removing more code from here
  • Consolidates the 2 docker jobs to 1
  • Helper bash script isn't really useful now that default build args are set
  • Upgraded the locked pipenv version. Lastest one seems stable
  • In some future time, the builder packages and cache here can be removed and the cleaner can run against the other repo only

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other (please explain) - CI maintence

Checklist:

  • I have read & agree with the contributing guidelines.
  • If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.
  • If applicable, I have checked that all tests pass, see documentation.
  • I have run all pre-commit hooks, see documentation.
  • I have made corresponding changes to the documentation as needed.
  • I have checked my modifications for any breaking changes.

@paperless-ngx-secretary paperless-ngx-secretary bot added ci-cd documentation Improvements or additions to documentation non-trivial Requires approval by several team members labels Apr 28, 2023
@github-actions github-actions bot added the enhancement New feature label Apr 28, 2023
@stumpylog stumpylog removed documentation Improvements or additions to documentation enhancement New feature labels Apr 29, 2023
Copy link
Member

@shamoon shamoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont pretend to fully understand every line of change here but overall seems like will yield big speed improvements to ci, etc. I really love the new image build instructions =)

Thanks as always for the persistent improvement

Edit (build worked perfectly fine for me, and quick)

@stumpylog
Copy link
Member Author

There's at least some documentation over at the builder repo. But I would like to put some details together somewhere to help understand both the process here and the general architecture of paperless.

Removes the building of installers from the repo, they can now be built elsewhere,
on demand, as their building is no longer tied to the Dockerfile
@stumpylog stumpylog marked this pull request as ready for review May 2, 2023 17:10
@stumpylog stumpylog requested review from a team as code owners May 2, 2023 17:10
@shamoon shamoon added this to the Next Release milestone May 5, 2023
@stumpylog stumpylog merged commit 02b2bca into dev May 5, 2023
27 checks passed
@stumpylog stumpylog deleted the feature-ci-improvements branch May 5, 2023 18:47
@github-actions
Copy link
Contributor

github-actions bot commented Jun 5, 2023

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ci-cd non-trivial Requires approval by several team members
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants