Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Prevent erroneous warning when starting container #3262

Merged
merged 1 commit into from May 1, 2023

Conversation

stumpylog
Copy link
Member

Proposed change

Noticed in #3244, there is a warning output when using this setting, because it looks like a user trying to set something via a secret, but the file won't exist, because they aren't.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other (please explain)

Checklist:

  • I have read & agree with the contributing guidelines.
  • If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.
  • If applicable, I have checked that all tests pass, see documentation.
  • I have run all pre-commit hooks, see documentation.
  • I have made corresponding changes to the documentation as needed.
  • I have checked my modifications for any breaking changes.

@stumpylog stumpylog requested a review from a team as a code owner May 1, 2023 01:10
@github-actions github-actions bot added the bug Bug report or a Bug-fix label May 1, 2023
Copy link
Member

@shamoon shamoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ha, yea seems like the simplest solution

@stumpylog stumpylog merged commit 613b71d into dev May 1, 2023
31 checks passed
@stumpylog stumpylog deleted the chore/silence-erroneous-docker-warn branch May 1, 2023 14:23
@shamoon shamoon added this to the v1.14.3 milestone May 1, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 1, 2023

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Bug report or a Bug-fix small-change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants