Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump filelock from 3.10.2 to 3.12.0 to fix permissions bug #3282

Merged
merged 1 commit into from May 2, 2023

Conversation

rbrownwsws
Copy link
Contributor

Proposed change

Fixes #3253

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other (please explain)

Checklist:

  • I have read & agree with the contributing guidelines.
  • If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.
  • If applicable, I have checked that all tests pass, see documentation.
  • I have run all pre-commit hooks, see documentation.
  • I have made corresponding changes to the documentation as needed.
  • I have checked my modifications for any breaking changes.

@rbrownwsws rbrownwsws requested a review from a team as a code owner May 2, 2023 11:34
@paperless-ngx-secretary
Copy link

Hello @rbrownwsws,

thank you very much for submitting this PR to us!

This is what will happen next:

  1. My robotic colleagues will check your changes to see if they break anything. You can see the progress below.
  2. Once that is finished, human contributors from paperless-ngx review your changes. Since this seems to be a small change, only a single contributor has to review your changes.
  3. Please improve anything that comes up during the review until your pull request gets approved.
  4. Your pull request will be merged into the dev branch. Changes there will be tested further.
  5. Eventually, changes from you and other contributors will be merged into main and a new release will be made.

Please allow up to 7 days for an initial review. We're all very excited about new pull requests but we only do this as a hobby.
If any action will be required by you, please reply within a month.

@github-actions github-actions bot added the bug Bug report or a Bug-fix label May 2, 2023
Copy link
Member

@stumpylog stumpylog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thank you

@stumpylog stumpylog merged commit ee3cf8e into paperless-ngx:dev May 2, 2023
19 checks passed
@shamoon
Copy link
Member

shamoon commented May 2, 2023

Cheers thanks

@rbrownwsws rbrownwsws deleted the fix-buggy-filelock branch May 7, 2023 06:14
@github-actions
Copy link
Contributor

github-actions bot commented Jun 7, 2023

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Bug report or a Bug-fix small-change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] File system permissions error in 1.14.2 prevents uploading or editing documents
3 participants