Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Inversion in tagged mail searching #3305

Merged
merged 1 commit into from
May 4, 2023
Merged

Conversation

stumpylog
Copy link
Member

Proposed change

We want emails without the keyword, not those with the keyword.

Fixes #3302

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other (please explain)

Checklist:

  • I have read & agree with the contributing guidelines.
  • If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.
  • If applicable, I have checked that all tests pass, see documentation.
  • I have run all pre-commit hooks, see documentation.
  • I have made corresponding changes to the documentation as needed.
  • I have checked my modifications for any breaking changes.

@stumpylog stumpylog requested a review from a team as a code owner May 3, 2023 21:32
@github-actions github-actions bot added the bug Bug report or a Bug-fix label May 3, 2023
@stumpylog stumpylog added this to the v1.14.4 milestone May 3, 2023
@stumpylog stumpylog changed the title Fixe: Inversion in tagged mail searching Fix: Inversion in tagged mail searching May 3, 2023
@codecov
Copy link

codecov bot commented May 3, 2023

Codecov Report

Merging #3305 (552b029) into dev (fd84fc9) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##              dev    #3305   +/-   ##
=======================================
  Coverage   93.35%   93.35%           
=======================================
  Files         156      156           
  Lines        6664     6664           
=======================================
  Hits         6221     6221           
  Misses        443      443           
Flag Coverage Δ
backend 93.35% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/paperless_mail/mail.py 88.23% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@stumpylog stumpylog merged commit 29d8c4e into dev May 4, 2023
31 checks passed
@stumpylog stumpylog deleted the fix/3302-mail-tag-search branch May 4, 2023 13:29
@github-actions
Copy link
Contributor

github-actions bot commented Jun 4, 2023

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backend bug Bug report or a Bug-fix small-change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Email tag rule inverted for non Gmail labels
2 participants