Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: default frontend to current owner, allow setting no owner on create #3347

Merged
merged 1 commit into from May 10, 2023

Conversation

shamoon
Copy link
Member

@shamoon shamoon commented May 8, 2023

Proposed change

Fix is two-fold:

  • UI should visibly default to current user for object creation
  • API / UI should 'override' default owner if the set_permissions object explicitly has owner set to empty

Fixes #3346

3347.mov

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other (please explain)

Checklist:

  • I have read & agree with the contributing guidelines.
  • If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.
  • If applicable, I have checked that all tests pass, see documentation.
  • I have run all pre-commit hooks, see documentation.
  • I have made corresponding changes to the documentation as needed.
  • I have checked my modifications for any breaking changes.

@shamoon shamoon added this to the Next Release milestone May 8, 2023
@shamoon shamoon requested review from a team as code owners May 8, 2023 09:27
@paperless-ngx-secretary paperless-ngx-secretary bot added backend frontend non-trivial Requires approval by several team members labels May 8, 2023
@github-actions github-actions bot added the bug Bug report or a Bug-fix label May 8, 2023
@codecov
Copy link

codecov bot commented May 8, 2023

Codecov Report

Merging #3347 (515146d) into dev (0aa9462) will increase coverage by 0.16%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              dev    #3347      +/-   ##
==========================================
+ Coverage   93.30%   93.47%   +0.16%     
==========================================
  Files         156      156              
  Lines        6675     6678       +3     
==========================================
+ Hits         6228     6242      +14     
+ Misses        447      436      -11     
Flag Coverage Δ
backend 93.47% <100.00%> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/documents/serialisers.py 92.15% <100.00%> (+0.47%) ⬆️

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@shamoon shamoon merged commit f78f212 into dev May 10, 2023
27 checks passed
@shamoon shamoon deleted the fix/issue-3346 branch May 10, 2023 15:18
@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backend bug Bug report or a Bug-fix frontend non-trivial Requires approval by several team members
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Owner of new correspondent is automatically set by backend, creates visibility issue
2 participants