Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: quick filters from document detail #3476

Merged
merged 1 commit into from Jun 1, 2023

Conversation

shamoon
Copy link
Member

@shamoon shamoon commented May 28, 2023

Proposed change

This PR adds a "quick filter" button next to the fields on the doc details page, see video. Basically this allows you to quickly find docs with the same date / correspondent / doc type / storage path / tags. I debated where to put the buttons but in the end this seemed the best option (imho).

qf.mov

Fixes # (theres a FR somewhere)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other (please explain)

Checklist:

  • I have read & agree with the contributing guidelines.
  • If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.
  • If applicable, I have checked that all tests pass, see documentation.
  • I have run all pre-commit hooks, see documentation.
  • I have made corresponding changes to the documentation as needed.
  • I have checked my modifications for any breaking changes.

@shamoon shamoon requested a review from a team as a code owner May 28, 2023 07:02
@paperless-ngx-secretary paperless-ngx-secretary bot added frontend non-trivial Requires approval by several team members labels May 28, 2023
@github-actions github-actions bot added the enhancement New feature label May 28, 2023
@shamoon shamoon force-pushed the feature-detail-quick-filters branch from 664d996 to 5d00fb0 Compare May 30, 2023 15:36
@shamoon shamoon force-pushed the feature-detail-quick-filters branch from 5d00fb0 to 74c965d Compare May 30, 2023 15:38
@stumpylog
Copy link
Member

I'm assuming the tags quick filter looks for that exact set of tags? Or is it more of an OR type search?

@shamoon
Copy link
Member Author

shamoon commented May 30, 2023

Yea at the moment it's an AND, so yea, contains all. I debated e.g. OR but I thought that seemed too 'loose' when actually using this.

Eg, I look at a yearly insurance thing with tags "Insurance", "Auto", "VW Bus" and I can click the button to quickly show me all the other invoices (or the correspondent etc) whereas OR would show me all of my (non-auto) insurance docs, etc.

Copy link
Member

@stumpylog stumpylog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An AND type makes sense for tags. I'll trust you on the code portions!

@shamoon
Copy link
Member Author

shamoon commented Jun 1, 2023

I'll trust you on the code portions!

Thanks! I'm working on something to mitigate this =)

@shamoon shamoon merged commit d62340e into dev Jun 1, 2023
27 checks passed
@shamoon shamoon deleted the feature-detail-quick-filters branch June 1, 2023 20:52
@github-actions
Copy link
Contributor

github-actions bot commented Jul 2, 2023

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature frontend non-trivial Requires approval by several team members
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants