Fix: Better error handling and checking when parsing documents via Tika #3617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paperless-ngx-secretary
bot
added
backend
non-trivial
|
I should probably add a "live" test for a doc file as well |
…ent via Tika Signed-off-by: Trenton Holmes <797416+stumpylog@users.noreply.github.com>
stumpylog
force-pushed
the
fix/3614-doc-document-parse
branch
from
3546ead
to
e943e86
Compare
Codecov Report
@@ Coverage Diff @@
## dev #3617 +/- ##
==========================================
+ Coverage 93.79% 95.11% +1.32%
==========================================
Files 157 331 +174
Lines 6723 12496 +5773
Branches 0 1093 +1093
==========================================
+ Hits 6306 11886 +5580
- Misses 417 605 +188
- Partials 0 5 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 174 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
shamoon
force-pushed
the
dev
branch
2 times, most recently
from
be97585
to
4693632
Compare
shamoon
approved these changes
Jun 18, 2023
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
My little library for Tikas API got some updates to refine its handling of Tika's response for document types it hasn't encountered and our code did too. It now just double checks there is content, in a couple different ways.
Fixes #3614
Type of change
Checklist:
pre-commithooks, see documentation.