Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Updates codecov configuration for the flag settings and notification delay #3656

Merged
merged 1 commit into from Jun 22, 2023

Conversation

stumpylog
Copy link
Member

@stumpylog stumpylog commented Jun 21, 2023

Proposed change

If I've set this up right, Codecov will now wait for 1 each upload for the frontend and backend flags before making a comment. That could be from either the commit CI or the pull request CI.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other (please explain) CI

Checklist:

  • I have read & agree with the contributing guidelines.
  • If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.
  • If applicable, I have checked that all tests pass, see documentation.
  • I have run all pre-commit hooks, see documentation.
  • I have made corresponding changes to the documentation as needed.
  • I have checked my modifications for any breaking changes.

@paperless-ngx-secretary paperless-ngx-secretary bot added the non-trivial Requires approval by several team members label Jun 21, 2023
@stumpylog stumpylog added ci-cd and removed non-trivial Requires approval by several team members labels Jun 21, 2023
@stumpylog stumpylog changed the title Chore:Updates codecov configuration for the flag settings and notification delay Chore: Updates codecov configuration for the flag settings and notification delay Jun 21, 2023
Copy link
Member

@shamoon shamoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, so it'll only comment on the relevant part (frontend vs backend) depending on the actual changes?

@stumpylog
Copy link
Member Author

No, it's always going to include change, if any, for both flags. This should make it wait until both coverages have uploaded before commenting. And hopefully make it less likely to comment when there's no actual changes

@shamoon
Copy link
Member

shamoon commented Jun 22, 2023

Ah gotcha, yea let’s go for it, nbd obviously

@stumpylog stumpylog merged commit ed6cb14 into dev Jun 22, 2023
29 checks passed
@stumpylog stumpylog deleted the chore/code-cov-settings-update branch June 22, 2023 15:20
@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants