Fix/enhancement: permissions for mail rules & accounts #3869
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Permissions for mail rules / accounts was basically never implemented, Im surprised it took this look to come up. Straightforward to do, it uses all existing code. Also the frontend was checking for
Change
(global) permissions instead ofDelete
on the button but of course the backend should have disallowed that too (it now does, screenshot just demonstrates this but the user wouldn't even see the button like the second screenshot).Ps. Setting permissions for these on the frontend isn't implemented yet.
Fixes #3868
Type of change
Checklist:
pre-commit
hooks, see documentation.