Fix: cancel possibly slow queries on doc details #3925
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
This issue seems most noticeable on suggestions which can be very slow on some machines. The fix is simple (and probably should have been written this way from the start), just cancel queries when e.g. navigating away. Video demonstrates this (for testing I added
time.sleep(60)
into the suggestions view), without these changes the requests remain pending.Fixes #3715
unsubscribe.mov
Type of change
Checklist:
If applicable, I have included testing coverage for new code in this PR, for backend and / or front-end changes.pre-commit
hooks, see documentation.