Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: cancel possibly slow queries on doc details #3925

Merged
merged 1 commit into from Aug 4, 2023

Conversation

shamoon
Copy link
Member

@shamoon shamoon commented Aug 4, 2023

Proposed change

This issue seems most noticeable on suggestions which can be very slow on some machines. The fix is simple (and probably should have been written this way from the start), just cancel queries when e.g. navigating away. Video demonstrates this (for testing I added time.sleep(60) into the suggestions view), without these changes the requests remain pending.

Fixes #3715

unsubscribe.mov

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other (please explain):

Checklist:

  • I have read & agree with the contributing guidelines.
  • If applicable, I have included testing coverage for new code in this PR, for backend and / or front-end changes.
  • If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.
  • If applicable, I have checked that all tests pass, see documentation.
  • I have run all pre-commit hooks, see documentation.
  • I have made corresponding changes to the documentation as needed.
  • I have checked my modifications for any breaking changes.

@shamoon shamoon added this to the Next Release milestone Aug 4, 2023
@shamoon shamoon requested a review from a team as a code owner August 4, 2023 04:56
@github-actions github-actions bot added the bug Bug report or a Bug-fix label Aug 4, 2023
@alexgrahamuk
Copy link

Fantastic fix 😁

@shamoon shamoon enabled auto-merge August 4, 2023 13:42
@shamoon shamoon merged commit 6a8bdbd into dev Aug 4, 2023
29 checks passed
@shamoon shamoon deleted the fix/cancel-slow-queries branch August 4, 2023 14:22
@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2023

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Bug report or a Bug-fix frontend small-change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Web interface hangs after changing between documents
3 participants