Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: handle very old date strings in correspondent list #3953

Merged
merged 1 commit into from Aug 8, 2023
Merged

Conversation

shamoon
Copy link
Member

@shamoon shamoon commented Aug 7, 2023

Proposed change

Certainly an esoteric bug:

  1. Have a timezone set (I think any)
  2. Use a very old date on a doc e.g. 1833-01-01T00:00:00+00:34:08 in the example
  3. Make sure that it is the most recent doc for that correspondent
  4. Open the management list

Its actually very similar to #818

Fixes #3944

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other (please explain):

Checklist:

  • I have read & agree with the contributing guidelines.
  • If applicable, I have included testing coverage for new code in this PR, for backend and / or front-end changes.
  • If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.
  • If applicable, I have checked that all tests pass, see documentation.
  • I have run all pre-commit hooks, see documentation.
  • I have made corresponding changes to the documentation as needed.
  • I have checked my modifications for any breaking changes.

@shamoon shamoon requested a review from a team as a code owner August 7, 2023 22:58
@paperless-ngx-secretary paperless-ngx-secretary bot added frontend non-trivial Requires approval by several team members labels Aug 7, 2023
@github-actions github-actions bot added the bug Bug report or a Bug-fix label Aug 7, 2023
@codecov
Copy link

codecov bot commented Aug 7, 2023

Codecov Report

Merging #3953 (421e78a) into dev (b961df9) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##              dev    #3953   +/-   ##
=======================================
  Coverage   95.26%   95.27%           
=======================================
  Files         335      335           
  Lines       12724    12729    +5     
  Branches     1047     1049    +2     
=======================================
+ Hits        12122    12127    +5     
  Misses        597      597           
  Partials        5        5           
Flag Coverage Δ
backend 94.09% <ø> (ø)
frontend 96.67% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...correspondent-list/correspondent-list.component.ts 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@shamoon shamoon enabled auto-merge August 8, 2023 00:31
@shamoon shamoon changed the title Handle very old date strings in correspondent list Fix: handle very old date strings in correspondent list Aug 8, 2023
@shamoon shamoon merged commit edad1a4 into dev Aug 8, 2023
27 checks passed
@shamoon shamoon deleted the fix/issue-3944 branch August 8, 2023 13:59
@shamoon shamoon added this to the Next Release milestone Aug 13, 2023
@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Bug report or a Bug-fix frontend non-trivial Requires approval by several team members
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] manage correspondents page errors with very old dates
2 participants