Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: add --id-range for document_retagger #4080

Merged
merged 3 commits into from Sep 8, 2023

Conversation

kamilkosek
Copy link
Contributor

Proposed change

Introduces --id-range option for the document_retagger, to be able to run the retagger only for a subset of documents.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other (please explain):

Checklist:

  • I have read & agree with the contributing guidelines.
  • If applicable, I have included testing coverage for new code in this PR, for backend and / or front-end changes.
  • If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.
  • If applicable, I have checked that all tests pass, see documentation.
  • I have run all pre-commit hooks, see documentation.
  • I have made corresponding changes to the documentation as needed.
  • I have checked my modifications for any breaking changes.

@kamilkosek kamilkosek requested a review from a team as a code owner August 28, 2023 18:49
@paperless-ngx-secretary paperless-ngx-secretary bot added backend documentation Improvements or additions to documentation small-change labels Aug 28, 2023
@paperless-ngx-secretary
Copy link

Hello @kamilkosek,

thank you very much for submitting this PR to us!

This is what will happen next:

  1. My robotic colleagues will check your changes to see if they break anything. You can see the progress below.
  2. Once that is finished, human contributors from paperless-ngx review your changes. Since this seems to be a small change, only a single contributor has to review your changes.
  3. Please improve anything that comes up during the review until your pull request gets approved.
  4. Your pull request will be merged into the dev branch. Changes there will be tested further.
  5. Eventually, changes from you and other contributors will be merged into main and a new release will be made.

Please allow up to 7 days for an initial review. We're all very excited about new pull requests but we only do this as a hobby.
If any action will be required by you, please reply within a month.

@codecov
Copy link

codecov bot commented Aug 28, 2023

Codecov Report

Merging #4080 (e519757) into dev (a8e13df) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head e519757 differs from pull request most recent head c44dc91. Consider uploading reports for the commit c44dc91 to get more accurate results

@@            Coverage Diff             @@
##              dev    #4080      +/-   ##
==========================================
- Coverage   95.31%   95.31%   -0.01%     
==========================================
  Files         338      338              
  Lines       12795    12789       -6     
  Branches     1054     1054              
==========================================
- Hits        12196    12190       -6     
  Misses        594      594              
  Partials        5        5              
Flag Coverage Δ
backend 94.10% <100.00%> (ø)
frontend 96.76% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...documents/management/commands/document_retagger.py 97.61% <100.00%> (+0.18%) ⬆️

... and 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@shamoon shamoon changed the title Intruduce --id-range for document_retagger Enhancement: add --id-range for document_retagger Aug 28, 2023
@shamoon shamoon removed the documentation Improvements or additions to documentation label Aug 28, 2023
@stumpylog
Copy link
Member

Could you add a quick test?

@shamoon shamoon added this to the v2.0.0 milestone Aug 29, 2023
@shamoon shamoon enabled auto-merge (squash) September 8, 2023 17:21
@shamoon shamoon merged commit b238ba0 into paperless-ngx:dev Sep 8, 2023
12 checks passed
@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2023

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants