Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: When PDF/A rendering fails, add a consideration for the user to add args to override #4083

Merged
merged 1 commit into from Aug 29, 2023

Conversation

stumpylog
Copy link
Member

Proposed change

Fixes #4067

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other (please explain):

Checklist:

  • I have read & agree with the contributing guidelines.
  • If applicable, I have included testing coverage for new code in this PR, for backend and / or front-end changes.
  • If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.
  • If applicable, I have checked that all tests pass, see documentation.
  • I have run all pre-commit hooks, see documentation.
  • I have made corresponding changes to the documentation as needed.
  • I have checked my modifications for any breaking changes.

@stumpylog stumpylog requested a review from a team as a code owner August 29, 2023 00:47
@github-actions github-actions bot added the bug Bug report or a Bug-fix label Aug 29, 2023
Copy link
Member

@shamoon shamoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

Merging #4083 (50dc9d3) into dev (d22a6fb) will decrease coverage by 0.03%.
The diff coverage is 40.00%.

@@            Coverage Diff             @@
##              dev    #4083      +/-   ##
==========================================
- Coverage   95.31%   95.29%   -0.03%     
==========================================
  Files         338      338              
  Lines       12779    12784       +5     
  Branches     1054     1054              
==========================================
+ Hits        12180    12182       +2     
- Misses        594      597       +3     
  Partials        5        5              
Flag Coverage Δ
backend 94.05% <40.00%> (-0.04%) ⬇️
frontend 96.76% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/paperless_tesseract/parsers.py 88.48% <40.00%> (-1.31%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@shamoon shamoon added this to the Next Release milestone Aug 29, 2023
@stumpylog stumpylog enabled auto-merge (rebase) August 29, 2023 01:04
@stumpylog stumpylog merged commit 7e768bf into dev Aug 29, 2023
28 of 29 checks passed
@stumpylog stumpylog deleted the fix/4067-pdfa-render branch August 29, 2023 01:10
@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backend bug Bug report or a Bug-fix small-change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SubprocessOutputError: Ghostscript PDF/A rendering failed
2 participants