Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: update docker image & ci testing node to v18 #4149

Merged
merged 1 commit into from
Sep 8, 2023

Conversation

shamoon
Copy link
Member

@shamoon shamoon commented Sep 8, 2023

Proposed change

Even though node v20 will enter LTS in like a month we cant upgrade to that because of angular/angular-cli#25782 (which I suspect will literally be fixed in the next couple days). Not a big deal, I think, as node versions dont seem to come with huge improvements. This does resolve https://github.com/paperless-ngx/paperless-ngx/actions/runs/6123228728/job/16621724619#step:11:430

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other (please explain): chore

Checklist:

  • I have read & agree with the contributing guidelines.
  • If applicable, I have included testing coverage for new code in this PR, for backend and / or front-end changes.
  • If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.
  • If applicable, I have checked that all tests pass, see documentation.
  • I have run all pre-commit hooks, see documentation.
  • I have made corresponding changes to the documentation as needed.
  • I have checked my modifications for any breaking changes.

@shamoon shamoon added frontend dependencies Pull requests that update a dependency file labels Sep 8, 2023
@github-actions github-actions bot added the enhancement New feature label Sep 8, 2023
@shamoon shamoon enabled auto-merge (squash) September 8, 2023 20:13
@stumpylog
Copy link
Member

Should the CI testing add v18 as well?

@shamoon shamoon force-pushed the feature-chore-update-node branch 2 times, most recently from 8390e56 to a80ffe1 Compare September 8, 2023 20:23
@shamoon shamoon requested a review from a team as a code owner September 8, 2023 20:23
@shamoon
Copy link
Member Author

shamoon commented Sep 8, 2023

It most certainly should, my bad. Fixed

@shamoon shamoon changed the title Chore: update docker image node to v18 Chore: update docker image & ci testing node to v18 Sep 8, 2023
@shamoon shamoon added this to the v2.0.0 milestone Sep 8, 2023
Copy link
Member

@stumpylog stumpylog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a status got lost by GH, but looks good

@shamoon shamoon merged commit b9fdf68 into dev Sep 8, 2023
31 checks passed
@shamoon shamoon deleted the feature-chore-update-node branch September 8, 2023 23:48
@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2023

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Pull requests that update a dependency file enhancement New feature frontend small-change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants