Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: update docker image and ci to node 20 #4184

Merged
merged 1 commit into from Sep 14, 2023

Conversation

shamoon
Copy link
Member

@shamoon shamoon commented Sep 14, 2023

Proposed change

The aforementioned bug was resolved in node 20.6.1 nodejs/node#49500 so safe to upgrade, already confirmed on ci

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other (please explain):

Checklist:

  • I have read & agree with the contributing guidelines.
  • If applicable, I have included testing coverage for new code in this PR, for backend and / or front-end changes.
  • If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.
  • If applicable, I have checked that all tests pass, see documentation.
  • I have run all pre-commit hooks, see documentation.
  • I have made corresponding changes to the documentation as needed.
  • I have checked my modifications for any breaking changes.

@shamoon shamoon requested a review from a team as a code owner September 14, 2023 17:32
@shamoon shamoon added this to the v2.0.0 milestone Sep 14, 2023
@github-actions github-actions bot added the enhancement New feature label Sep 14, 2023
@stumpylog stumpylog enabled auto-merge (rebase) September 14, 2023 17:38
@stumpylog stumpylog merged commit 3a36d9b into dev Sep 14, 2023
29 checks passed
@stumpylog stumpylog deleted the feature-chore-update-node-20 branch September 14, 2023 20:06
@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants