New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement: dashboard improvements, drag-n-drop reorder dashboard views #4252
Conversation
b5c2831
to
4c7c6e7
Compare
Codecov Report
@@ Coverage Diff @@
## dev #4252 +/- ##
==========================================
+ Coverage 95.65% 95.78% +0.13%
==========================================
Files 356 358 +2
Lines 13588 13682 +94
Branches 1081 1094 +13
==========================================
+ Hits 12997 13105 +108
+ Misses 586 573 -13
+ Partials 5 4 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
4c7c6e7
to
684c6d5
Compare
Ah great, fail on the first try 😑 Hmm, I think there may have been an issue where the drag-and-drops were interacting in a weird way (I remembered to turn off global file drop if moving the widgets but forgot the other way around). I still couldn't exactly reproduce the same error as above though, but let me know if youre still seeing it (and if so maybe a video or if there's a more specific set of steps?). |
Pull request was converted to draft
260c3e4
to
d8184c4
Compare
Pull request was converted to draft
fcc396c
to
e1eda34
Compare
you are doing some nice stuff! Thanks for the work (loving the consumption template pr :) ) |
d4bd954
to
9494901
Compare
af53d8b
to
ce5f052
Compare
ce5f052
to
4ebd0c8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems pretty solid now. Reordering works and d&d is solid on Windows especially.
…ews (#4252) * Updated dashboard * Make entire screen dropzone on dashboard too * Floating upload widget status alerts * Visual tweaks: spacing, borders * Better empty view widget * Support drag + drop reorder of dashboard saved views * Update messages.xlf * Disable dashbaord dnd if global dnd active * Remove ngx-file-drop dep, rebuild file-drop & upload files widget * Revert custom file drop implementation * Try patch-package fix * Simplify dropzone transitions to make more reliable * Update messages.xlf * Update dashboard.spec.ts * Fix coverage
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns. |
Proposed change
Opening a pair of UI PRs (not dependent on each other) in honor of v2. Appreciate any feedback. This PR gives the dashboard some love. Screenshots and video below.
The biggest challenge with updating the dashboard was that I pushed the upload widget down and made it smaller, the potential problems caused by this are mitigated with:
Edit: as pointed out by stumpylog the drag-n-drop package has a bad bug, so attempted to apply georgipeltekov/ngx-file-drop#294 via https://www.npmjs.com/package/patch-package...
sortable.mov
I'll update screenshots in the docs once these PRs are done / merged.
Fixes #1818
Type of change
Checklist:
pre-commit
hooks, see documentation.