Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: speed-up frontend tests on ci #4316

Merged
merged 1 commit into from Oct 5, 2023
Merged

CI: speed-up frontend tests on ci #4316

merged 1 commit into from Oct 5, 2023

Conversation

shamoon
Copy link
Member

@shamoon shamoon commented Oct 4, 2023

Proposed change

Speeds up frontend tests from ~8-9 minutes to ~4-5

Only other note about this is that I had to play with the download/upload artifact for the coverage files a bit. At the moment it downloads all artifacts (to keep it in one step) and then filters out backend coverage on upload to codecov. The download is still super fast (at this point only other artifact is docs) so seems OK. Alternatively we could have 4 steps for each frontend artifact but this seems cleaner. Of course welcome any improvements.

Unfortunately I didnt find anything (obvious) similar to this for the backend tests. Maybe if we figure out conditionally running tests in the future we can reap the full benefits of this.

Oh, and I also cleaned up some names etc =)

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other (please explain): CI

Checklist:

  • I have read & agree with the contributing guidelines.
  • If applicable, I have included testing coverage for new code in this PR, for backend and / or front-end changes.
  • If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.
  • If applicable, I have checked that all tests pass, see documentation.
  • I have run all pre-commit hooks, see documentation.
  • I have made corresponding changes to the documentation as needed.
  • I have checked my modifications for any breaking changes.

@shamoon shamoon requested review from a team as code owners October 4, 2023 21:41
@paperless-ngx-secretary paperless-ngx-secretary bot added ci-cd frontend non-trivial Requires approval by several team members labels Oct 4, 2023
@github-actions github-actions bot added the enhancement New feature label Oct 4, 2023
@shamoon shamoon enabled auto-merge (squash) October 4, 2023 21:42
@shamoon shamoon merged commit 57b8ee3 into dev Oct 5, 2023
35 checks passed
@shamoon shamoon deleted the feature/speedup-jest-ci branch October 5, 2023 02:35
Copy link
Contributor

github-actions bot commented Nov 4, 2023

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ci-cd enhancement New feature frontend non-trivial Requires approval by several team members
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants