Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: get highest ASN regardless of user #4326

Merged
merged 1 commit into from Oct 7, 2023
Merged

Fix: get highest ASN regardless of user #4326

merged 1 commit into from Oct 7, 2023

Conversation

shamoon
Copy link
Member

@shamoon shamoon commented Oct 6, 2023

Proposed change

This is the simple fix, we're not dealing with multiple ASN groups etc, for now.

Fixes #4325

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other (please explain):

Checklist:

  • I have read & agree with the contributing guidelines.
  • If applicable, I have included testing coverage for new code in this PR, for backend and / or front-end changes.
  • If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.
  • If applicable, I have checked that all tests pass, see documentation.
  • I have run all pre-commit hooks, see documentation.
  • I have made corresponding changes to the documentation as needed.
  • I have checked my modifications for any breaking changes.

@shamoon shamoon requested review from a team as code owners October 6, 2023 15:00
@paperless-ngx-secretary paperless-ngx-secretary bot added backend frontend non-trivial Requires approval by several team members labels Oct 6, 2023
@github-actions github-actions bot added the bug Bug report or a Bug-fix label Oct 6, 2023
@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

Merging #4326 (406173b) into dev (a2bdd64) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##              dev    #4326   +/-   ##
=======================================
  Coverage   95.78%   95.78%           
=======================================
  Files         359      359           
  Lines       13692    13692           
  Branches     1094     1092    -2     
=======================================
  Hits        13115    13115           
  Misses        573      573           
  Partials        4        4           
Flag Coverage Δ
backend 94.49% <100.00%> (+<0.01%) ⬆️
frontend 97.30% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...components/common/input/number/number.component.ts 100.00% <100.00%> (ø)
src-ui/src/app/services/rest/document.service.ts 97.18% <100.00%> (+0.08%) ⬆️
src/documents/views.py 95.37% <100.00%> (+0.02%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@shamoon shamoon enabled auto-merge (squash) October 6, 2023 16:03
@shamoon shamoon added this to the v2.0.0 milestone Oct 6, 2023
@shamoon shamoon merged commit f7f5d0e into dev Oct 7, 2023
35 checks passed
@shamoon shamoon deleted the fix/issue-4325 branch October 7, 2023 00:22
shamoon added a commit that referenced this pull request Oct 13, 2023
Copy link
Contributor

github-actions bot commented Nov 6, 2023

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backend bug Bug report or a Bug-fix frontend non-trivial Requires approval by several team members
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Wrong ASN on "+1" Button with multiuser
2 participants