Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: separate frontend deps install #4336

Merged
merged 1 commit into from Oct 9, 2023
Merged

CI: separate frontend deps install #4336

merged 1 commit into from Oct 9, 2023

Conversation

shamoon
Copy link
Member

@shamoon shamoon commented Oct 8, 2023

Proposed change

Im not sure it will speed things up (I was kinda hoping it would) despite the caching but hopefully this will prevent e.g.
https://github.com/paperless-ngx/paperless-ngx/actions/runs/6422630429/job/17439543900

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other (please explain):

Checklist:

  • I have read & agree with the contributing guidelines.
  • If applicable, I have included testing coverage for new code in this PR, for backend and / or front-end changes.
  • If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.
  • If applicable, I have checked that all tests pass, see documentation.
  • I have run all pre-commit hooks, see documentation.
  • I have made corresponding changes to the documentation as needed.
  • I have checked my modifications for any breaking changes.

@shamoon shamoon requested a review from a team as a code owner October 8, 2023 02:43
@paperless-ngx-secretary paperless-ngx-secretary bot added ci-cd non-trivial Requires approval by several team members labels Oct 8, 2023
@shamoon shamoon enabled auto-merge (squash) October 8, 2023 02:43
@shamoon shamoon disabled auto-merge October 8, 2023 02:43
@shamoon shamoon enabled auto-merge (squash) October 8, 2023 02:44
stumpylog
stumpylog approved these changes Oct 9, 2023
View reviewed changes
Copy link
Member

@stumpylog stumpylog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll defer to you on what needs caching. Actual CI changes are good to me

@shamoon shamoon merged commit f170cc0 into dev Oct 9, 2023
39 checks passed
@shamoon shamoon deleted the ci/separate-frontend-deps branch October 9, 2023 16:44
shamoon added a commit that referenced this pull request Oct 13, 2023
@shamoon
CI: Install frontend dependencies separately, once (#4336)
4e10f21
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 9, 2023

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stumpylog stumpylog stumpylog approved these changes

Assignees
No one assigned
Labels
ci-cd non-trivial Requires approval by several team members
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shamoon @stumpylog