Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking: Rename the environment variable for self-signed email certificates #4346

Merged
merged 1 commit into from Oct 9, 2023

Conversation

stumpylog
Copy link
Member

@stumpylog stumpylog commented Oct 9, 2023

Proposed change

I should have named this differently in the first place. It gets read during the env-from-file, which could be confusing, as it will read the file and set a variable with the _FILE trimmed. It's not needed and a user might wonder what's happening.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other (please explain):

Checklist:

  • I have read & agree with the contributing guidelines.
  • If applicable, I have included testing coverage for new code in this PR, for backend and / or front-end changes.
  • If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.
  • If applicable, I have checked that all tests pass, see documentation.
  • I have run all pre-commit hooks, see documentation.
  • I have made corresponding changes to the documentation as needed.
  • I have checked my modifications for any breaking changes.

@stumpylog stumpylog requested a review from a team as a code owner October 9, 2023 17:24
@paperless-ngx-secretary paperless-ngx-secretary bot added backend documentation Improvements or additions to documentation small-change labels Oct 9, 2023
@stumpylog stumpylog removed documentation Improvements or additions to documentation backend labels Oct 9, 2023
@shamoon
Copy link
Member

shamoon commented Oct 9, 2023

This will be a breaking change, yea?

@stumpylog
Copy link
Member Author

Yes. Since there's already some for v2, this seems like the best time to do so.

@codecov
Copy link

codecov bot commented Oct 9, 2023

Codecov Report

Merging #4346 (31b7250) into dev (e52ae28) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##              dev    #4346   +/-   ##
=======================================
  Coverage   95.78%   95.78%           
=======================================
  Files         359      359           
  Lines       13696    13696           
  Branches     1092     1092           
=======================================
  Hits        13119    13119           
  Misses        573      573           
  Partials        4        4           
Flag Coverage Δ
backend 94.49% <100.00%> (ø)
frontend 97.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/paperless/settings.py 89.41% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@shamoon shamoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, yea agree, as good a time as any

@shamoon shamoon added this to the v2.0.0 milestone Oct 9, 2023
@stumpylog stumpylog merged commit b18b070 into dev Oct 9, 2023
37 checks passed
@stumpylog stumpylog deleted the breaking/file-env-renames branch October 9, 2023 21:47
Copy link
Contributor

github-actions bot commented Nov 9, 2023

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants