Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Updates to latest imap_tools which includes fix for the meta charset in HTML content #4355

Merged
merged 1 commit into from Oct 11, 2023

Conversation

stumpylog
Copy link
Member

Proposed change

This update includes fixes so that meta tags describing the charset will be reset to UTF-8, after the library converts the HTML into UTF-8 from whatever the defined charset say. So UTF-8, declared as UTF-8 content, results in working special characters.

Fixes #4297

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other (please explain):

Checklist:

  • I have read & agree with the contributing guidelines.
  • If applicable, I have included testing coverage for new code in this PR, for backend and / or front-end changes.
  • If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.
  • If applicable, I have checked that all tests pass, see documentation.
  • I have run all pre-commit hooks, see documentation.
  • I have made corresponding changes to the documentation as needed.
  • I have checked my modifications for any breaking changes.

@stumpylog stumpylog requested a review from a team as a code owner October 11, 2023 02:41
@github-actions github-actions bot added the bug Bug report or a Bug-fix label Oct 11, 2023
Copy link
Member

@shamoon shamoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@stumpylog stumpylog merged commit db0f31a into dev Oct 11, 2023
39 checks passed
@stumpylog stumpylog deleted the fix/4297-html-charset branch October 11, 2023 13:32
shamoon pushed a commit that referenced this pull request Oct 13, 2023
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Bug report or a Bug-fix small-change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Emails with text/html containing Windows-1252 charset rendered wrong.
2 participants