New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Audit Trail #4425
Feature: Audit Trail #4425
Conversation
Hello @nanokatz, thank you very much for submitting this PR to us! This is what will happen next:
Please allow up to 7 days for an initial review. We're all very excited about new pull requests but we only do this as a hobby. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this would definitely be a cool feature but besides the things noted (small, mostly), my big concern is that this is in no way surfaced to the frontend. In general, do we want to be adding features that are only visible via the Django interface?
Im not sure it would be so challenging to do, but at the moment this PR is just adding the audit-log dependency. I personally think it wouldn't make sense unless we include a frontend way to use this.
Not sure what others think
That was an active choice on my side. I wanted there to be a log; and for it to be accesible but in an out of the way place. Turns out it was very easy as you noted. I should add a note to the documentation though that it is only acessible in the django admin otherwise its not clear. |
…into dev Because I screwed up....
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just some small notes, I think there are other issues I'll leave to backend
Co-authored-by: shamoon <4887959+shamoon@users.noreply.github.com>
Co-authored-by: shamoon <4887959+shamoon@users.noreply.github.com>
…t the moment with a note (not currently visible in the admin site) that it was due to redo ocr request
Codecov Report
@@ Coverage Diff @@
## dev #4425 +/- ##
=======================================
Coverage 95.89% 95.89%
=======================================
Files 359 359
Lines 13712 13725 +13
Branches 1094 1094
=======================================
+ Hits 13149 13162 +13
Misses 559 559
Partials 4 4
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking care of business stumpy
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns. |
Proposed change
Enables an audit trail for each document,document type, correspondent, and tag. This records all changes made to the documents to meet requirement such as GoDB.
Uses django-auditlog and once enabled cannot be disabled to maintain the log.
Type of change
Checklist:
pre-commit
hooks, see documentation.