Fix: Only create a Correspondent if the email matches rule filters #4431
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
I agree this isn't correct behavior or at the very least unexpected. This small fix makes it so Correspondents are only created if there is a message or attachment matching the filters, in addition to matching the IMAP criteria. So if a "From" or "Subject" matches, but the attachment filename doesn't, there will not be a Correspondent created early.
Fixes #4429
Type of change
Checklist:
pre-commit
hooks, see documentation.