Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: add permissions for custom fields with migration #4513

Merged
merged 1 commit into from Nov 6, 2023

Conversation

shamoon
Copy link
Member

@shamoon shamoon commented Nov 6, 2023

Proposed change

I forgot to include this in #4502 but as we did for consumption templates I think we should automatically add (global) permissions for custom field objects upon migration. Especially since not having these perms will cause issues on docs that have fields attached. I edited the migration rather than a new one since we havent released that yet, obv. Welcome any thoughts.

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other (please explain):

Checklist:

  • I have read & agree with the contributing guidelines.
  • If applicable, I have included testing coverage for new code in this PR, for backend and / or front-end changes.
  • If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.
  • If applicable, I have checked that all tests pass, see documentation.
  • I have run all pre-commit hooks, see documentation.
  • I have made corresponding changes to the documentation as needed.
  • I have checked my modifications for any breaking changes.

@shamoon shamoon requested a review from a team as a code owner November 6, 2023 03:09
@paperless-ngx-secretary paperless-ngx-secretary bot added backend non-trivial Requires approval by several team members labels Nov 6, 2023
@shamoon shamoon added this to the v2.0.0 milestone Nov 6, 2023
@github-actions github-actions bot added the bug Bug report or a Bug-fix label Nov 6, 2023
@shamoon shamoon enabled auto-merge (squash) November 6, 2023 03:09
@shamoon shamoon merged commit 24dbf66 into dev Nov 6, 2023
34 checks passed
@shamoon shamoon deleted the fix/custom-field-permissions branch November 6, 2023 16:05
Copy link
Contributor

github-actions bot commented Dec 7, 2023

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backend bug Bug report or a Bug-fix non-trivial Requires approval by several team members
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants