Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: sidebar views dont update after creation in v2.0.0-beta.rc1 #4619

Merged
merged 1 commit into from Nov 17, 2023

Conversation

shamoon
Copy link
Member

@shamoon shamoon commented Nov 17, 2023

Proposed change

Good one to fix. Issue was just making a copy of the views as opposed to always using the (up-to-date) array from the service.

4618.mov

Fixes #4618

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other (please explain):

Checklist:

  • I have read & agree with the contributing guidelines.
  • If applicable, I have included testing coverage for new code in this PR, for backend and / or front-end changes.
  • If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.
  • If applicable, I have checked that all tests pass, see documentation.
  • I have run all pre-commit hooks, see documentation.
  • I have made corresponding changes to the documentation as needed.
  • I have checked my modifications for any breaking changes.

Copy link

codecov bot commented Nov 17, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ed34815) 96.01% compared to head (f7059d8) 96.01%.

Additional details and impacted files
@@            Coverage Diff             @@
##             beta    #4619      +/-   ##
==========================================
- Coverage   96.01%   96.01%   -0.01%     
==========================================
  Files         371      371              
  Lines       14158    14157       -1     
  Branches     1110     1110              
==========================================
- Hits        13594    13593       -1     
  Misses        560      560              
  Partials        4        4              
Flag Coverage Δ
backend 94.66% <ø> (ø)
frontend 97.59% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shamoon shamoon merged commit 00aa6c1 into beta Nov 17, 2023
29 checks passed
@shamoon shamoon deleted the fix/issue-4618 branch November 17, 2023 17:41
@shamoon shamoon added this to the v2.0.0 milestone Nov 23, 2023
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants