Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Import of split-manifests can fail #4623

Merged
merged 1 commit into from Nov 17, 2023
Merged

Fix: Import of split-manifests can fail #4623

merged 1 commit into from Nov 17, 2023

Conversation

stumpylog
Copy link
Member

Proposed change

It requires the usage of the split manifest, but manifest.json gets imported first, and it contains the ContentType and Permission exports. But then the other document manifests are imported and those just imported objects are deleted.

Fixes #4622

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other (please explain):

Checklist:

  • I have read & agree with the contributing guidelines.
  • If applicable, I have included testing coverage for new code in this PR, for backend and / or front-end changes.
  • If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.
  • If applicable, I have checked that all tests pass, see documentation.
  • I have run all pre-commit hooks, see documentation.
  • I have made corresponding changes to the documentation as needed.
  • I have checked my modifications for any breaking changes.

@stumpylog stumpylog requested a review from a team as a code owner November 17, 2023 19:35
@stumpylog stumpylog linked an issue Nov 17, 2023 that may be closed by this pull request
[BUG] Error migrating instances using document_exporter with split-manifest #4622
Closed
shamoon
shamoon approved these changes Nov 17, 2023
View reviewed changes
Copy link
Member

@shamoon shamoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks stumpy!

@shamoon shamoon changed the title Only delete the ContentTypes and Permissions once, not the loop Fix: Import of split-manifests can fail Nov 17, 2023
@stumpylog stumpylog merged commit a94e5d2 into beta Nov 17, 2023
27 checks passed
@stumpylog stumpylog deleted the fix/4622-split-content-types branch November 17, 2023 20:24
@stumpylog
Copy link
Member Author

Thanks for catching the title

@stumpylog stumpylog mentioned this pull request Nov 17, 2023
Closed
@shamoon shamoon mentioned this pull request Nov 17, 2023
Merged
@shamoon shamoon added this to the v2.0.0 milestone Nov 23, 2023
shamoon pushed a commit that referenced this pull request Nov 26, 2023
@stumpylog @shamoon
Only delete the ContentTypes and Permissions once, not the loop (#4623)
23bd366
shamoon pushed a commit that referenced this pull request Nov 26, 2023
@stumpylog @shamoon
Only delete the ContentTypes and Permissions once, not the loop (#4623)
97f69ee
@github-actions GitHub Actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shamoon shamoon shamoon approved these changes

Assignees
No one assigned
Labels
backend small-change
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.

[BUG] Error migrating instances using document_exporter with split-manifest
2 participants
@stumpylog @shamoon