Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: dashboard saved view mobile width in v.2.0.0 beta.rc1 #4660

Merged
merged 1 commit into from Nov 22, 2023

Conversation

shamoon
Copy link
Member

@shamoon shamoon commented Nov 22, 2023

Proposed change

Repro:

  • FF
  • empty saved view
  • small window size

Fix:
Screenshot 2023-11-22 at 11 38 44 AM
Before:
Screenshot 2023-11-22 at 11 39 07 AM

Fixes #4579 (reply in thread)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other (please explain):

Checklist:

  • I have read & agree with the contributing guidelines.
  • If applicable, I have included testing coverage for new code in this PR, for backend and / or front-end changes.
  • If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.
  • If applicable, I have checked that all tests pass, see documentation.
  • I have run all pre-commit hooks, see documentation.
  • I have made corresponding changes to the documentation as needed.
  • I have checked my modifications for any breaking changes.

@shamoon shamoon requested a review from a team as a code owner November 22, 2023 19:45
@shamoon shamoon merged commit b83e6a5 into beta Nov 22, 2023
29 checks passed
@shamoon shamoon deleted the fix/2.0.0-beta-dashboard-saved-view-mobile-width branch November 22, 2023 20:37
@shamoon shamoon added this to the v2.0.0 milestone Nov 23, 2023
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant