Fix: respect baseURI for pdfjs worker URL

[shamoon]

Proposed change

As usual, users always point out things not on my radar.

Fixes #4848

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Other (please explain):

Checklist:

• I have read & agree with the contributing guidelines.
• If applicable, I have included testing coverage for new code in this PR, for backend and / or front-end changes.
• If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.
• If applicable, I have checked that all tests pass, see documentation.
• I have run all pre-commit hooks, see documentation.
• I have made corresponding changes to the documentation as needed.
• I have checked my modifications for any breaking changes.

[stumpylog]

Was this from bringing that dependency internal that changed its location?

[shamoon]

Yes, precisely. Basically we now bundle our own PDF.js version and we have to specify the worker file location. But actually it might even be simpler to use a relative URL, I'm going to mark this as draft to check it out (build a new image).

[shamoon]

Ok yea, fix is even simpler. Since we set the documentURI we just use a relative path (that’s what we did before, just now in a different place). just wanted to make sure the user who opened the above issue confirmed this solves it 👍

[stumpylog]

Even easier, thanks!

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns.