Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: allow text copy in pngx pdf viewer #4938

Merged
merged 1 commit into from Dec 12, 2023
Merged

Fix: allow text copy in pngx pdf viewer #4938

merged 1 commit into from Dec 12, 2023

Conversation

shamoon
Copy link
Member

@shamoon shamoon commented Dec 11, 2023

Proposed change

I dont understand why we didnt have this issue previously since we were setting the render text mode but I dont think we ever wanted that, let it use the defaults instead.

To clarify Im almost certain the user in the linked thread is only having this in the browser PDF viewer because he's loading it after visiting the doc details page with our viewer first, which sets a global variable that gets picked up by PDFJS (which again, browser PDF viewers almost all use). Edit: confirmed its just the pngx viewer as suspected

I created a feature image, but here's video:

4936.mov

Fixes #4936

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other (please explain):

Checklist:

  • I have read & agree with the contributing guidelines.
  • If applicable, I have included testing coverage for new code in this PR, for backend and / or front-end changes.
  • If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.
  • If applicable, I have checked that all tests pass, see documentation.
  • I have run all pre-commit hooks, see documentation.
  • I have made corresponding changes to the documentation as needed.
  • I have checked my modifications for any breaking changes.

@shamoon shamoon requested a review from a team as a code owner December 11, 2023 20:23
@shamoon shamoon added this to the Next Bugfix Release milestone Dec 11, 2023
@github-actions github-actions bot added bug Bug report or a Bug-fix enhancement New feature labels Dec 11, 2023
@shamoon shamoon enabled auto-merge (squash) December 11, 2023 22:13
@shamoon shamoon merged commit 1a48910 into dev Dec 12, 2023
25 checks passed
@shamoon shamoon deleted the feature-fix-4936 branch December 12, 2023 01:06
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Bug report or a Bug-fix enhancement New feature frontend small-change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

STRG+C is not working inside the pdf view
2 participants