Fix: allow text copy in pngx pdf viewer #4938
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
I dont understand why we didnt have this issue previously since we were setting the render text mode but I dont think we ever wanted that, let it use the defaults instead.
To clarify Im almost certain the user in the linked thread is only having this in the browser PDF viewer because he's loading it after visiting the doc details page with our viewer first, which sets a global variable that gets picked up by PDFJS (which again, browser PDF viewers almost all use).Edit: confirmed its just the pngx viewer as suspectedI created a feature image, but here's video:
4936.mov
Fixes #4936
Type of change
Checklist:
pre-commit
hooks, see documentation.