Chore: Update Angular to v17 including new Angular control-flow #4980

shamoon · 2023-12-14T16:09:43Z

Proposed change

Obviously tests pass but will want to get some hands-on testing just to be sure

Definitely a bit bigger of a change than usual upgrades. Besides some necessary changes to get this to build (only real thing is removing --omit-optional which came from npm/cli#4828 , this also migrates to Angular v17's new control flow, see https://blog.angular.io/meet-angulars-new-control-flow-a02c6eee7843 . It's supposed to be more performant, though that might be hard to actually appreciate on an individual level, certainly the way of the future.

This PR will need to be updated as other PRs get merged in (easier to merge them all in and then this one, I think)

Fixes # (issue)

Type of change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Other (please explain):

Checklist:

I have read & agree with the contributing guidelines.
If applicable, I have included testing coverage for new code in this PR, for backend and / or front-end changes.
If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.
If applicable, I have checked that all tests pass, see documentation.
I have run all pre-commit hooks, see documentation.
I have made corresponding changes to the documentation as needed.
I have checked my modifications for any breaking changes.

codecov · 2023-12-14T16:16:28Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5e8de4c) 96.19% compared to head (e50e98c) 96.20%.

Additional details and impacted files

@@           Coverage Diff           @@
##              dev    #4980   +/-   ##
=======================================
  Coverage   96.19%   96.20%           
=======================================
  Files         382      382           
  Lines       14651    14654    +3     
  Branches     1161     1162    +1     
=======================================
+ Hits        14094    14098    +4     
+ Misses        553      552    -1     
  Partials        4        4

Flag	Coverage Δ
backend	`94.76% <ø> (ø)`
frontend	`97.84% <100.00%> (+0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

shamoon · 2023-12-19T21:50:00Z

Ok, I've updated this after all the other PRs that touched the frontend got merged, so this one should be ready to go.

Obviously a code review is not all that practical here, the commits are separate for the curious but all of the control flow changes were done automatically by the angular cli.

Of course the tests still pass but I also just kicked the tires a bit to make sure as well as pulled the feature image.

stumpylog

I poked around the UI some as well and didn't see any issues either. Thanks for all the work

commit 8a0a49d Author: shamoon <4887959+shamoon@users.noreply.github.com> Date: Tue Dec 19 23:02:47 2023 -0800 Fix formatting commit 66b2d90 Author: shamoon <4887959+shamoon@users.noreply.github.com> Date: Tue Dec 19 22:36:35 2023 -0800 Refactor frontend data models commit 5723bd8 Author: Adam Bogdał <adam@bogdal.pl> Date: Wed Dec 20 01:17:43 2023 +0100 Fix: speed up admin panel for installs with a large number of documents (#5052) commit 9b08ce1 Author: shamoon <4887959+shamoon@users.noreply.github.com> Date: Tue Dec 19 15:18:51 2023 -0800 Update PULL_REQUEST_TEMPLATE.md commit a6248be Author: shamoon <4887959+shamoon@users.noreply.github.com> Date: Tue Dec 19 15:02:05 2023 -0800 Chore: Update Angular to v17 (#4980) commit b1f6f52 Author: shamoon <4887959+shamoon@users.noreply.github.com> Date: Tue Dec 19 13:53:56 2023 -0800 Fix: Dont allow null custom_fields property via API (#5063) commit 638d997 Author: shamoon <4887959+shamoon@users.noreply.github.com> Date: Tue Dec 19 13:43:50 2023 -0800 Enhancement: symmetric document links (#4907) commit 5e8de4c Author: shamoon <4887959+shamoon@users.noreply.github.com> Date: Tue Dec 19 12:45:04 2023 -0800 Enhancement: shared icon & shared by me filter (#4859) commit 088bad9 Author: Trenton H <797416+stumpylog@users.noreply.github.com> Date: Tue Dec 19 12:04:03 2023 -0800 Bulk updates all the backend libraries (#5061)

* Saving some start on this * At least partially working for the tesseract parser * Problems with migration testing need to figure out * Work around that error * Fixes max m_pixels * Moving the settings to main paperless application * Starting some consumer options * More fixes and work * Fixes these last tests * Fix max_length on OcrSettings.mode field * Fix all fields on Common & Ocr settings serializers * Umbrellla config view * Revert "Umbrellla config view" This reverts commit fbaf9f4. * Updates to use a single configuration object for all settings * Squashed commit of the following: commit 8a0a49d Author: shamoon <4887959+shamoon@users.noreply.github.com> Date: Tue Dec 19 23:02:47 2023 -0800 Fix formatting commit 66b2d90 Author: shamoon <4887959+shamoon@users.noreply.github.com> Date: Tue Dec 19 22:36:35 2023 -0800 Refactor frontend data models commit 5723bd8 Author: Adam Bogdał <adam@bogdal.pl> Date: Wed Dec 20 01:17:43 2023 +0100 Fix: speed up admin panel for installs with a large number of documents (#5052) commit 9b08ce1 Author: shamoon <4887959+shamoon@users.noreply.github.com> Date: Tue Dec 19 15:18:51 2023 -0800 Update PULL_REQUEST_TEMPLATE.md commit a6248be Author: shamoon <4887959+shamoon@users.noreply.github.com> Date: Tue Dec 19 15:02:05 2023 -0800 Chore: Update Angular to v17 (#4980) commit b1f6f52 Author: shamoon <4887959+shamoon@users.noreply.github.com> Date: Tue Dec 19 13:53:56 2023 -0800 Fix: Dont allow null custom_fields property via API (#5063) commit 638d997 Author: shamoon <4887959+shamoon@users.noreply.github.com> Date: Tue Dec 19 13:43:50 2023 -0800 Enhancement: symmetric document links (#4907) commit 5e8de4c Author: shamoon <4887959+shamoon@users.noreply.github.com> Date: Tue Dec 19 12:45:04 2023 -0800 Enhancement: shared icon & shared by me filter (#4859) commit 088bad9 Author: Trenton H <797416+stumpylog@users.noreply.github.com> Date: Tue Dec 19 12:04:03 2023 -0800 Bulk updates all the backend libraries (#5061) * Saving some work on frontend config * Very basic but dynamically-generated config form * Saving work on slightly less ugly frontend config * JSON validation for user_args field * Fully dynamic config form * Adds in some additional validators for a nicer error message * Cleaning up the testing and coverage more * Reverts unintentional change * Adds documentation about the settings and the precedence * Couple more commenting and style fixes --------- Co-authored-by: shamoon <4887959+shamoon@users.noreply.github.com>

github-actions · 2024-01-19T03:03:52Z

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns.

shamoon requested a review from a team as a code owner December 14, 2023 16:09

paperless-ngx-secretary bot added documentation Improvements or additions to documentation frontend non-trivial Requires approval by several team members labels Dec 14, 2023

github-actions bot added the enhancement New feature label Dec 14, 2023

shamoon added this to the Next Feature Release milestone Dec 14, 2023

stumpylog removed the documentation Improvements or additions to documentation label Dec 14, 2023

shamoon added 5 commits December 14, 2023 13:17

Migrate to angular v17, remove deprecated ngbAccordion directives

d17fb83

Update Angular control flow

0d7474d

Resolve some change detection issues

a34404e

Update frontend strings

0f5b902

Make codecov happy

07ee42e

shamoon force-pushed the feature-chore-angular-17 branch from d786555 to 07ee42e Compare December 14, 2023 21:19

shamoon marked this pull request as draft December 19, 2023 20:39

shamoon added 5 commits December 19, 2023 12:53

Merge branch 'dev' into feature-chore-angular-17

e7a7946

Re-apply control flow changes after merge of dev

5d87725

Update messages.xlf

9402842

Merge branch 'dev' into feature-chore-angular-17

3259fde

Re-apply control flow changes after merge of dev, again

e50e98c

shamoon marked this pull request as ready for review December 19, 2023 21:50

shamoon enabled auto-merge December 19, 2023 21:50

stumpylog approved these changes Dec 19, 2023

View reviewed changes

shamoon disabled auto-merge December 19, 2023 23:01

shamoon merged commit a6248be into dev Dec 19, 2023
30 checks passed

shamoon deleted the feature-chore-angular-17 branch December 19, 2023 23:02

shamoon changed the title ~~Chore: Update Angular to v17~~ Chore: Update Angular to v17 including new Angular control-flow Dec 19, 2023

github-actions bot locked as resolved and limited conversation to collaborators Jan 19, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Chore: Update Angular to v17 including new Angular control-flow #4980

Chore: Update Angular to v17 including new Angular control-flow #4980

shamoon commented Dec 14, 2023

codecov bot commented Dec 14, 2023 •

edited

shamoon commented Dec 19, 2023

stumpylog left a comment

github-actions bot commented Jan 19, 2024

Chore: Update Angular to v17 including new Angular control-flow #4980

Chore: Update Angular to v17 including new Angular control-flow #4980

Conversation

shamoon commented Dec 14, 2023

Proposed change

Type of change

Checklist:

codecov bot commented Dec 14, 2023 • edited

Codecov Report

shamoon commented Dec 19, 2023

stumpylog left a comment

Choose a reason for hiding this comment

github-actions bot commented Jan 19, 2024

codecov bot commented Dec 14, 2023 •

edited