Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Apply user arguments even in the case of the forcing OCR #4981

Merged
merged 1 commit into from Dec 14, 2023

Conversation

stumpylog
Copy link
Member

Proposed change

Updating the already existing warning a little bit as well.

Fixes #4971

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other (please explain):

Checklist:

  • I have read & agree with the contributing guidelines.
  • If applicable, I have included testing coverage for new code in this PR, for backend and / or front-end changes.
  • If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.
  • If applicable, I have checked that all tests pass, see documentation.
  • I have run all pre-commit hooks, see documentation.
  • I have made corresponding changes to the documentation as needed.
  • I have checked my modifications for any breaking changes.

@stumpylog stumpylog requested a review from a team as a code owner December 14, 2023 18:09
@paperless-ngx-secretary paperless-ngx-secretary bot added backend documentation Improvements or additions to documentation small-change labels Dec 14, 2023
@github-actions github-actions bot added the bug Bug report or a Bug-fix label Dec 14, 2023
Copy link

codecov bot commented Dec 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (72000ca) 96.12% compared to head (812bcd0) 96.12%.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #4981   +/-   ##
=======================================
  Coverage   96.12%   96.12%           
=======================================
  Files         379      379           
  Lines       14540    14540           
  Branches     1143     1143           
=======================================
  Hits        13976    13976           
  Misses        560      560           
  Partials        4        4           
Flag Coverage Δ
backend 94.75% <100.00%> (ø)
frontend 97.68% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@shamoon shamoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks stumpy, short and sweet 👍

Makes sense to me, the only place we do this is

args = self.construct_ocrmypdf_parameters(
when the rasterized parser didnt find any text

@stumpylog stumpylog merged commit 92a9200 into dev Dec 14, 2023
31 checks passed
@stumpylog stumpylog deleted the fix/4971-user-args-fallback branch December 14, 2023 19:20
@stumpylog stumpylog added this to the Next Bugfix Release milestone Dec 15, 2023
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backend bug Bug report or a Bug-fix documentation Improvements or additions to documentation small-change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] OCR_USER_ARGS not used when forcing ocr
2 participants