Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: saving doc links with no value #5144

Merged
merged 1 commit into from Dec 28, 2023
Merged

Fix: saving doc links with no value #5144

merged 1 commit into from Dec 28, 2023

Conversation

shamoon
Copy link
Member

@shamoon shamoon commented Dec 28, 2023

Proposed change

Closes #5143

Type of change

  • Bug fix: non-breaking change which fixes an issue.
  • New feature: non-breaking change which adds functionality. Please read the important note above.
  • Breaking change: fix or feature that would cause existing functionality to not work as expected.
  • Documentation only.
  • Other. Please explain:

Checklist:

  • I have read & agree with the contributing guidelines.
  • If applicable, I have included testing coverage for new code in this PR, for backend and / or front-end changes.
  • If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.
  • If applicable, I have checked that all tests pass, see documentation.
  • I have run all pre-commit hooks, see documentation.
  • I have made corresponding changes to the documentation as needed.
  • I have checked my modifications for any breaking changes.

@shamoon shamoon requested a review from a team as a code owner December 28, 2023 19:50
@github-actions github-actions bot added the bug Bug report or a Bug-fix label Dec 28, 2023
@shamoon shamoon enabled auto-merge (squash) December 28, 2023 19:51
Copy link
Member

@stumpylog stumpylog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, beat me to it

@shamoon shamoon merged commit 7600110 into dev Dec 28, 2023
26 checks passed
@shamoon shamoon deleted the fix/5143-null-doc-links branch December 28, 2023 19:57
@shamoon
Copy link
Member Author

shamoon commented Dec 28, 2023

Ha, yea just cause I feel bad about these little ones. Glad to root them out.

@shamoon shamoon added this to the Next Release milestone Dec 29, 2023
@shamoon shamoon mentioned this pull request Dec 30, 2023
3 tasks
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backend bug Bug report or a Bug-fix small-change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] TypeError: 'NoneType' object is not iterable
2 participants