New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement: add storage_path
parameter to post_document API
#5217
Enhancement: add storage_path
parameter to post_document API
#5217
Conversation
Hello @bevanjkay, thank you very much for submitting this PR to us! This is what will happen next:
Please allow up to 7 days for an initial review. We're all very excited about new pull requests but we only do this as a hobby. |
storage_path
parameter to post_document APIstorage_path
parameter to post_document API
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #5217 +/- ##
==========================================
+ Coverage 96.02% 96.30% +0.28%
==========================================
Files 372 392 +20
Lines 14184 15013 +829
Branches 1114 1169 +55
==========================================
+ Hits 13620 14459 +839
+ Misses 560 550 -10
Partials 4 4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@shamoon Thanks for running CI, it looks like the failing test is a workflow issue, and not an issue with the PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks the PR, I just fixed the coverage.
Seems pretty safe since this is basically copied from the other fields.
Thanks for updating the missing test @shamoon |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns. |
Proposed change
This PR adds an additional parameter to the
post_document
API endpoint to allow setting astorage_path
.Closes #5211
Type of change
Checklist:
pre-commit
hooks, see documentation.