Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deployment: Use the default Docker healthcheck from the Dockerfile (Part 2) #5224

Merged

Conversation

ColinHebert
Copy link
Contributor

Proposed change

Use the docker healthcheck provided in the docker image, this way the healthcheck is centralised and doesn't need to be re-declared in each docker-compose.yml

This is the second step after #5199

Note: Do not merge this pull request until a new release of the paperless-ngx docker image.
As this removes superfluous healthcheck which are referenced in the documentation, those should be kept in place until the new images have been published to avoid any confusion for the users.

Type of change

  • Bug fix: non-breaking change which fixes an issue.
  • New feature: non-breaking change which adds functionality. Please read the important note above.
  • Breaking change: fix or feature that would cause existing functionality to not work as expected.
  • Documentation only.
  • Other. Please explain:

Checklist:

  • I have read & agree with the contributing guidelines.
  • If applicable, I have included testing coverage for new code in this PR, for backend and / or front-end changes.
  • If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.
  • If applicable, I have checked that all tests pass, see documentation.
  • I have run all pre-commit hooks, see documentation.
  • I have made corresponding changes to the documentation as needed.
  • I have checked my modifications for any breaking changes.

@paperless-ngx-secretary
Copy link

Hello @ColinHebert,

thank you very much for submitting this PR to us!

This is what will happen next:

  1. My robotic colleagues will check your changes to see if they break anything. You can see the progress below.
  2. Once that is finished, human contributors from paperless-ngx review your changes. Since this seems to be a small change, only a single contributor has to review your changes.
  3. Please improve anything that comes up during the review until your pull request gets approved.
  4. Your pull request will be merged into the dev branch. Changes there will be tested further.
  5. Eventually, changes from you and other contributors will be merged into main and a new release will be made.

Please allow up to 7 days for an initial review. We're all very excited about new pull requests but we only do this as a hobby.
If any action will be required by you, please reply within a month.

@stumpylog stumpylog marked this pull request as draft January 3, 2024 14:58
@shamoon shamoon marked this pull request as ready for review January 6, 2024 15:49
@shamoon shamoon changed the title Use the default Docker healthcheck from the Dockerfile (Part 2) Deployment: Use the default Docker healthcheck from the Dockerfile (Part 2) Jan 6, 2024
@stumpylog stumpylog enabled auto-merge (squash) January 7, 2024 16:45
Copy link

codecov bot commented Jan 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (30c31a3) 96.40% compared to head (39089d5) 96.40%.

❗ Current head 39089d5 differs from pull request most recent head 1c2576f. Consider uploading reports for the commit 1c2576f to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #5224      +/-   ##
==========================================
- Coverage   96.40%   96.40%   -0.01%     
==========================================
  Files         394      394              
  Lines       15424    15420       -4     
  Branches     1179     1179              
==========================================
- Hits        14870    14866       -4     
  Misses        550      550              
  Partials        4        4              
Flag Coverage Δ
backend 95.13% <ø> (-0.01%) ⬇️
frontend 97.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stumpylog stumpylog merged commit 4f85dce into paperless-ngx:dev Jan 7, 2024
18 checks passed
Copy link
Contributor

github-actions bot commented Feb 7, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants