Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Decoding of user arguments for OCR #5307

Merged
merged 1 commit into from Jan 7, 2024
Merged

Conversation

stumpylog
Copy link
Member

Proposed change

Closes #5303

Type of change

  • Bug fix: non-breaking change which fixes an issue.
  • New feature: non-breaking change which adds functionality. Please read the important note above.
  • Breaking change: fix or feature that would cause existing functionality to not work as expected.
  • Documentation only.
  • Other. Please explain:

Checklist:

  • I have read & agree with the contributing guidelines.
  • If applicable, I have included testing coverage for new code in this PR, for backend and / or front-end changes.
  • If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.
  • If applicable, I have checked that all tests pass, see documentation.
  • I have run all pre-commit hooks, see documentation.
  • I have made corresponding changes to the documentation as needed.
  • I have checked my modifications for any breaking changes.

@stumpylog stumpylog requested a review from a team as a code owner January 7, 2024 21:44
@github-actions github-actions bot added the bug Bug report or a Bug-fix label Jan 7, 2024
Copy link

codecov bot commented Jan 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2b39697) 96.40% compared to head (8d1ef6e) 96.40%.
Report is 1 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #5307   +/-   ##
=======================================
  Coverage   96.40%   96.40%           
=======================================
  Files         394      394           
  Lines       15420    15423    +3     
  Branches     1179     1179           
=======================================
+ Hits        14866    14869    +3     
  Misses        550      550           
  Partials        4        4           
Flag Coverage Δ
backend 95.14% <100.00%> (+<0.01%) ⬆️
frontend 97.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@shamoon shamoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh nice, glad I let you do this one, I was over-complicating it in my head. Thanks!

[2024-01-07 14:02:10,802] [DEBUG] [paperless.parsing.tesseract] Calling OCRmyPDF with args: {'input_file': PosixPath('/private/var/folders/1_/rlrvyw7x5b53z9ndk9_mlcvh0000gn/T/paperless/paperless-ngxwngus9yl/bug-test-workflows.pdf'), 'output_file': PosixPath('/private/var/folders/1_/rlrvyw7x5b53z9ndk9_mlcvh0000gn/T/paperless/paperless-oii7mus0/archive.pdf'), 'use_threads': True, 'jobs': 12, 'language': 'eng', 'output_type': 'pdfa', 'progress_bar': False, 'color_conversion_strategy': 'RGB', 'skip_text': True, 'clean': True, 'deskew': True, 'rotate_pages': True, 'rotate_pages_threshold': 12.0, 'sidecar': PosixPath('/private/var/folders/1_/rlrvyw7x5b53z9ndk9_mlcvh0000gn/T/paperless/paperless-oii7mus0/sidecar.txt'), 'invalidate_digital_signatures': True}

@shamoon shamoon added this to the Next Release milestone Jan 7, 2024
@stumpylog stumpylog enabled auto-merge (squash) January 7, 2024 22:06
@stumpylog
Copy link
Member Author

I'm not really sure why, but if the binary flag isn't set, the field just .. doesn't decode anything. Not really helpful there, DRF

@shamoon
Copy link
Member

shamoon commented Jan 7, 2024

Haha. Yea pretty sure it would’ve taken me ages to figure that out

@shamoon shamoon disabled auto-merge January 7, 2024 22:17
@shamoon shamoon merged commit ea47af7 into dev Jan 7, 2024
30 checks passed
@shamoon shamoon deleted the fix/5303-decode-json-in-json branch January 7, 2024 22:17
Copy link
Contributor

github-actions bot commented Feb 7, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backend bug Bug report or a Bug-fix small-change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] OCR arguments set in UI are not parsed correctly
2 participants