Fix: Don't require the JSON user arguments field, interpret empty string as null

[stumpylog]

Proposed change

Closes #5313

Type of change

• Bug fix: non-breaking change which fixes an issue.
• New feature: non-breaking change which adds functionality. Please read the important note above.
• Breaking change: fix or feature that would cause existing functionality to not work as expected.
• Documentation only.
• Other. Please explain:

Checklist:

• I have read & agree with the contributing guidelines.
• If applicable, I have included testing coverage for new code in this PR, for backend and / or front-end changes.
• If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.
• If applicable, I have checked that all tests pass, see documentation.
• I have run all pre-commit hooks, see documentation.
• I have made corresponding changes to the documentation as needed.
• I have checked my modifications for any breaking changes.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f525ac0) 96.40% compared to head (65fef9a) 96.41%.

Additional details and impacted files

@@           Coverage Diff           @@
##              dev    #5320   +/-   ##
=======================================
  Coverage   96.40%   96.41%           
=======================================
  Files         394      394           
  Lines       15424    15428    +4     
  Branches     1179     1179           
=======================================
+ Hits        14870    14875    +5     
+ Misses        550      549    -1     
  Partials        4        4           

Flag	Coverage Δ
backend	95.15% <100.00%> (+0.01%)	⬆️
frontend	97.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[shamoon]

My pytest is still borked but I can at least run the backend again 😅

I still get {"user_args":["Value must be valid JSON."]} with this?

[stumpylog]

I can't reproduce that from the image. The standard {"invalidate_digital_signatures": true} in the field works, and an empty field works now as well.

[shamoon]

Ah, I think if you set it, then delete the contents of the field the frontend will pass "" which is what fails. I suppose we can handle it in either place, I think this came up with #4762 where we handled it in the backend

[stumpylog]

Ah, the change without saving thing. I can add that fix in a bit

[stumpylog]

Really hating DRF here. It's not calling validate or update reliably for me when changing settings. Any idea what the heck it's doing?

[shamoon]

Sometimes it's so weird. I can look a bit later, alternatively would it be easier to make the frontend pass null for this field? It might be a bit of a pain but vs. fighting with DRF =)

Maybe I'll have some beginners luck

[shamoon]

Dont ask me why, but run_validation seems to do it, lmk if you notice any issues with it:

[stumpylog]

That seems fine to me. I'm going to ignore the coverage, it's an odd ball case to me.

[shamoon]

Dont mean to overstep but I took the liberty of adding a little coverage, happy to revert it if you dont want it

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns.