Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Explain behavior of unset app config boolean to user #5345

Merged
merged 1 commit into from Jan 10, 2024

Conversation

shamoon
Copy link
Member

@shamoon shamoon commented Jan 10, 2024

Proposed change

Small QoL UX thing I'd like to sneak into 2.3.3 that I forgot to resolve with app config. Basically the form currently shows boolean fields as having a value (e.g. disabled) but they're actually null until the user actually toggles it on or off meaning they dont yet apply. This just adds a little visual warning as such. Screenshots below hopefully show what I mean.

Screenshot 2024-01-10 at 1 43 37 PM Screenshot 2024-01-10 at 1 43 43 PM

Closes #5126 (comment)

Type of change

  • Bug fix: non-breaking change which fixes an issue.
  • New feature: non-breaking change which adds functionality. Please read the important note above.
  • Breaking change: fix or feature that would cause existing functionality to not work as expected.
  • Documentation only.
  • Other. Please explain: Change / enhancement / kind of fix

Checklist:

  • I have read & agree with the contributing guidelines.
  • If applicable, I have included testing coverage for new code in this PR, for backend and / or front-end changes.
  • If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.
  • If applicable, I have checked that all tests pass, see documentation.
  • I have run all pre-commit hooks, see documentation.
  • I have made corresponding changes to the documentation as needed.
  • I have checked my modifications for any breaking changes.

@shamoon shamoon requested a review from a team as a code owner January 10, 2024 22:33
@paperless-ngx-secretary paperless-ngx-secretary bot added frontend non-trivial Requires approval by several team members labels Jan 10, 2024
@shamoon shamoon enabled auto-merge (squash) January 10, 2024 22:34
@shamoon shamoon added this to the v2.3.3 milestone Jan 10, 2024
Copy link
Member

@stumpylog stumpylog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me, hopefully will reduce confusion

@shamoon shamoon merged commit 3dcb973 into dev Jan 10, 2024
31 checks passed
@shamoon shamoon deleted the app-config-unset-boolean branch January 10, 2024 23:34
@cdoepmann
Copy link

Perfect, thanks a lot for resolving this so quickly before I could even open a proper discussion or issue!

Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
frontend non-trivial Requires approval by several team members
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants