Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: app branding #5357

Merged
merged 18 commits into from Jan 13, 2024
Merged

Feature: app branding #5357

merged 18 commits into from Jan 13, 2024

Conversation

shamoon
Copy link
Member

@shamoon shamoon commented Jan 12, 2024

Proposed change

Uses the new app config

Screenshot 2024-01-11 at 10 51 58 PM Screenshot 2024-01-12 at 2 32 36 AM Screenshot 2024-01-12 at 8 48 10 AM

Closes #1428

Type of change

  • Bug fix: non-breaking change which fixes an issue.
  • New feature: non-breaking change which adds functionality. Please read the important note above.
  • Breaking change: fix or feature that would cause existing functionality to not work as expected.
  • Documentation only.
  • Other. Please explain:

Checklist:

  • I have read & agree with the contributing guidelines.
  • If applicable, I have included testing coverage for new code in this PR, for backend and / or front-end changes.
  • If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.
  • If applicable, I have checked that all tests pass, see documentation.
  • I have run all pre-commit hooks, see documentation.
  • I have made corresponding changes to the documentation as needed.
  • I have checked my modifications for any breaking changes.

@shamoon shamoon requested review from a team as code owners January 12, 2024 10:34
@paperless-ngx-secretary paperless-ngx-secretary bot added backend documentation Improvements or additions to documentation frontend non-trivial Requires approval by several team members labels Jan 12, 2024
@github-actions github-actions bot added the enhancement New feature label Jan 12, 2024
Copy link

codecov bot commented Jan 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2da5e46) 96.40% compared to head (ac77449) 96.42%.

❗ Current head ac77449 differs from pull request most recent head a6c03fd. Consider uploading reports for the commit a6c03fd to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #5357      +/-   ##
==========================================
+ Coverage   96.40%   96.42%   +0.02%     
==========================================
  Files         396      397       +1     
  Lines       15535    15539       +4     
  Branches     1180     1188       +8     
==========================================
+ Hits        14977    14984       +7     
+ Misses        554      551       -3     
  Partials        4        4              
Flag Coverage Δ
backend 95.16% <100.00%> (+<0.01%) ⬆️
frontend 97.92% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shamoon shamoon removed the documentation Improvements or additions to documentation label Jan 12, 2024
@shamoon shamoon marked this pull request as draft January 12, 2024 16:17
@shamoon
Copy link
Member Author

shamoon commented Jan 12, 2024

Just made a couple tweaks:

  • ability to remove a logo if set (not just replace)
  • make changing the title also change the window title

@shamoon shamoon marked this pull request as ready for review January 12, 2024 20:16
Copy link
Member

@stumpylog stumpylog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't notice any issues. Fancy how the title pops up right away

@shamoon shamoon enabled auto-merge (squash) January 13, 2024 19:50
@shamoon shamoon merged commit 2a6e79a into dev Jan 13, 2024
24 of 25 checks passed
@shamoon shamoon deleted the feature-app-branding branch January 13, 2024 19:57
@tmaier
Copy link

tmaier commented Jan 13, 2024

Thank you! ❤️

@shamoon shamoon added this to the Next Release milestone Jan 13, 2024
@shamoon
Copy link
Member Author

shamoon commented Jan 13, 2024

Thank you! ❤️

Welcome ☺️

Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backend enhancement New feature frontend non-trivial Requires approval by several team members
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants