Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: better bootstrap icons #5403

Merged
merged 13 commits into from Jan 18, 2024
Merged

Chore: better bootstrap icons #5403

merged 13 commits into from Jan 18, 2024

Conversation

shamoon
Copy link
Member

@shamoon shamoon commented Jan 15, 2024

Proposed change

Sorry, this is a bit of an absurd PR (in terms of diff size) but all it's really doing is replacing the way we use the bootstrap icons. Currently we reference an external svg file which:

  1. Causes some unsightly visual things, like this (and just watch the browser network when on e.g. tasks page and auto-refresh)
  2. Makes the releases unnecessarily larger.

This replaces them with an angular package, only loading in the ones we actually use and ultimately embeds the svg in the page so no loading delay.

Hopefully I caught all the little tweaks, I'll keep an eye out for more =)

Closes #(issue or discussion)

Type of change

  • Bug fix: non-breaking change which fixes an issue.
  • New feature: non-breaking change which adds functionality. Please read the important note above.
  • Breaking change: fix or feature that would cause existing functionality to not work as expected.
  • Documentation only.
  • Other. Please explain: chore dependencies

Checklist:

  • I have read & agree with the contributing guidelines.
  • If applicable, I have included testing coverage for new code in this PR, for backend and / or front-end changes.
  • If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.
  • If applicable, I have checked that all tests pass, see documentation.
  • I have run all pre-commit hooks, see documentation.
  • I have made corresponding changes to the documentation as needed.
  • I have checked my modifications for any breaking changes.

@shamoon shamoon requested a review from a team as a code owner January 15, 2024 05:40
@paperless-ngx-secretary paperless-ngx-secretary bot added frontend non-trivial Requires approval by several team members labels Jan 15, 2024
@github-actions github-actions bot added the enhancement New feature label Jan 15, 2024
Copy link

codecov bot commented Jan 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (dc1918a) 96.51% compared to head (3538f36) 96.51%.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #5403   +/-   ##
=======================================
  Coverage   96.51%   96.51%           
=======================================
  Files         400      400           
  Lines       15711    15714    +3     
  Branches     1197     1197           
=======================================
+ Hits        15163    15166    +3     
  Misses        544      544           
  Partials        4        4           
Flag Coverage Δ
backend 95.24% <ø> (ø)
frontend 98.02% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shamoon shamoon changed the title Enhancement: better bootstrap icons Chore: better bootstrap icons Jan 15, 2024
@shamoon shamoon added this to the Next Release milestone Jan 15, 2024
@stumpylog
Copy link
Member

Something I notice is the open documents has a scroll bar in this image:
image

@shamoon
Copy link
Member Author

shamoon commented Jan 16, 2024

Great catch thanks!

@shamoon shamoon enabled auto-merge (squash) January 16, 2024 00:25
@shamoon shamoon disabled auto-merge January 17, 2024 00:21
Copy link
Member Author

@shamoon shamoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Went through again line-by-line, a little annoying but hoping I've caught all the little things

Copy link
Member

@stumpylog stumpylog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't noticed any other missing or odd icons

@shamoon shamoon enabled auto-merge (squash) January 18, 2024 00:19
@shamoon shamoon merged commit bb98fc5 into dev Jan 18, 2024
27 checks passed
@shamoon shamoon deleted the feature-better-bs-icons branch January 18, 2024 00:27
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature frontend non-trivial Requires approval by several team members
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants