New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: better bootstrap icons #5403
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #5403 +/- ##
=======================================
Coverage 96.51% 96.51%
=======================================
Files 400 400
Lines 15711 15714 +3
Branches 1197 1197
=======================================
+ Hits 15163 15166 +3
Misses 544 544
Partials 4 4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Great catch thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Went through again line-by-line, a little annoying but hoping I've caught all the little things
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't noticed any other missing or odd icons
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns. |
Proposed change
Sorry, this is a bit of an absurd PR (in terms of diff size) but all it's really doing is replacing the way we use the bootstrap icons. Currently we reference an external svg file which:
This replaces them with an angular package, only loading in the ones we actually use and ultimately embeds the svg in the page so no loading delay.
Hopefully I caught all the little tweaks, I'll keep an eye out for more =)
Closes #(issue or discussion)
Type of change
Checklist:
pre-commit
hooks, see documentation.