Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: dont lose permissions ui if owner changed from null #5433

Merged
merged 1 commit into from Jan 17, 2024
Merged

Conversation

shamoon
Copy link
Member

@shamoon shamoon commented Jan 16, 2024

Proposed change

See linked issue, just wasnt including the case where current user is empty. Video below

5429.mov

Closes #5429

Type of change

  • Bug fix: non-breaking change which fixes an issue.
  • New feature: non-breaking change which adds functionality. Please read the important note above.
  • Breaking change: fix or feature that would cause existing functionality to not work as expected.
  • Documentation only.
  • Other. Please explain:

Checklist:

  • I have read & agree with the contributing guidelines.
  • If applicable, I have included testing coverage for new code in this PR, for backend and / or front-end changes.
  • If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.
  • If applicable, I have checked that all tests pass, see documentation.
  • I have run all pre-commit hooks, see documentation.
  • I have made corresponding changes to the documentation as needed.
  • I have checked my modifications for any breaking changes.

@shamoon shamoon added this to the Next Release milestone Jan 16, 2024
@shamoon shamoon requested a review from a team as a code owner January 16, 2024 22:53
@paperless-ngx-secretary paperless-ngx-secretary bot added frontend non-trivial Requires approval by several team members labels Jan 16, 2024
@github-actions github-actions bot added the bug Bug report or a Bug-fix label Jan 16, 2024
Copy link

codecov bot commented Jan 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ea632d0) 96.49% compared to head (fc0ed04) 96.48%.

❗ Current head fc0ed04 differs from pull request most recent head 8b0482d. Consider uploading reports for the commit 8b0482d to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #5433      +/-   ##
==========================================
- Coverage   96.49%   96.48%   -0.02%     
==========================================
  Files         400      400              
  Lines       15707    15704       -3     
  Branches     1193     1197       +4     
==========================================
- Hits        15157    15152       -5     
- Misses        546      548       +2     
  Partials        4        4              
Flag Coverage Δ
backend 95.19% <ø> (-0.05%) ⬇️
frontend 98.02% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shamoon shamoon enabled auto-merge (squash) January 17, 2024 04:09
@shamoon shamoon merged commit dc1918a into dev Jan 17, 2024
28 checks passed
@shamoon shamoon deleted the fix/5429 branch January 17, 2024 17:44
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Bug report or a Bug-fix frontend non-trivial Requires approval by several team members
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants