Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: confirm buttons #5680

Merged
merged 61 commits into from Feb 8, 2024
Merged

Enhancement: confirm buttons #5680

merged 61 commits into from Feb 8, 2024

Conversation

shamoon
Copy link
Member

@shamoon shamoon commented Feb 7, 2024

Proposed change

Small UI thing that came up in #5190 (and this PR is dependent on that just so the changes there are included). This adds a little confirmation to certain buttons in the UI. Eg:
Screenshot 2024-02-06 at 4 57 09 PM

Edit: I've narrowed down the scope of this PR, the button is used for:

  • Profile regenerate API key and disconnect social account
  • Workflow editing delete action and trigger (currently has no confirm)
  • Saved view delete (this actually had no confirm before, which seems inconsistent)
Screenshot 2024-02-06 at 8 52 53 PM Screenshot 2024-02-06 at 8 52 57 PM Screenshot 2024-02-06 at 10 23 48 PM Screenshot 2024-02-06 at 9 35 21 PM

Closes #(issue or discussion)

Type of change

  • Bug fix: non-breaking change which fixes an issue.
  • New feature / Enhancement: non-breaking change which adds functionality. Please read the important note above.
  • Breaking change: fix or feature that would cause existing functionality to not work as expected.
  • Documentation only.
  • Other. Please explain:

Checklist:

  • I have read & agree with the contributing guidelines.
  • If applicable, I have included testing coverage for new code in this PR, for backend and / or front-end changes.
  • If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.
  • If applicable, I have checked that all tests pass, see documentation.
  • I have run all pre-commit hooks, see documentation.
  • I have made corresponding changes to the documentation as needed.
  • I have checked my modifications for any breaking changes.

@shamoon
Copy link
Member Author

shamoon commented Feb 7, 2024

I've narrowed down the scope here.

@shamoon shamoon marked this pull request as ready for review February 8, 2024 16:20
@shamoon shamoon requested a review from a team as a code owner February 8, 2024 16:20
@shamoon shamoon enabled auto-merge (squash) February 8, 2024 16:21
@stumpylog
Copy link
Member

Maybe just to be cleaner, you could drop the extra commits?

@shamoon
Copy link
Member Author

shamoon commented Feb 8, 2024

I dont know if I can now that theres a merge commit, but when this is merged in it'll get squashed cleanly to the one commit, right?

@shamoon shamoon disabled auto-merge February 8, 2024 17:57
@shamoon shamoon enabled auto-merge (squash) February 8, 2024 17:58
@stumpylog
Copy link
Member

It probably will. I guess just make sure the co-authored isn't set?

@shamoon
Copy link
Member Author

shamoon commented Feb 8, 2024

Or I can open a new PR if you prefer

@shamoon shamoon disabled auto-merge February 8, 2024 17:59
@shamoon shamoon enabled auto-merge (squash) February 8, 2024 17:59
@shamoon
Copy link
Member Author

shamoon commented Feb 8, 2024

Yea, should be clean I think?

Screenshot 2024-02-08 at 9 59 29 AM

@shamoon
Copy link
Member Author

shamoon commented Feb 8, 2024

I'm just gonna open a new PR...

@shamoon shamoon closed this Feb 8, 2024
auto-merge was automatically disabled February 8, 2024 18:14

Pull request was closed

@shamoon shamoon reopened this Feb 8, 2024
@shamoon shamoon enabled auto-merge (squash) February 8, 2024 18:17
@shamoon
Copy link
Member Author

shamoon commented Feb 8, 2024

Ok sorted, sorry for the noise

@shamoon shamoon merged commit 6487dab into dev Feb 8, 2024
25 checks passed
@shamoon shamoon deleted the feature-confirm-buttons branch February 8, 2024 18:23
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns. See our contributing guidelines for more details.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants