New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement: confirm buttons #5680
Conversation
This reverts commit 3f0f894.
I've narrowed down the scope here. |
Maybe just to be cleaner, you could drop the extra commits? |
I dont know if I can now that theres a merge commit, but when this is merged in it'll get squashed cleanly to the one commit, right? |
It probably will. I guess just make sure the co-authored isn't set? |
Or I can open a new PR if you prefer |
I'm just gonna open a new PR... |
Ok sorted, sorry for the noise |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns. See our contributing guidelines for more details. |
Proposed change
Small UI thing that came up in #5190 (and this PR is dependent on that just so the changes there are included). This adds a little confirmation to certain buttons in the UI. Eg:
Edit: I've narrowed down the scope of this PR, the button is used for:
Closes #(issue or discussion)
Type of change
Checklist:
pre-commit
hooks, see documentation.