Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: handle document notes user format api change #5751

Merged
merged 1 commit into from Feb 13, 2024
Merged

Fix: handle document notes user format api change #5751

merged 1 commit into from Feb 13, 2024

Conversation

shamoon
Copy link
Member

@shamoon shamoon commented Feb 13, 2024

Proposed change

Im not certain which backend change introduced this (any ideas?), I left some legacy handling of the case that it returns the simple int

Closes #5747

Type of change

  • Bug fix: non-breaking change which fixes an issue.
  • New feature / Enhancement: non-breaking change which adds functionality. Please read the important note above.
  • Breaking change: fix or feature that would cause existing functionality to not work as expected.
  • Documentation only.
  • Other. Please explain:

Checklist:

  • I have read & agree with the contributing guidelines.
  • If applicable, I have included testing coverage for new code in this PR, for backend and / or front-end changes.
  • If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.
  • If applicable, I have checked that all tests pass, see documentation.
  • I have run all pre-commit hooks, see documentation.
  • I have made corresponding changes to the documentation as needed.
  • I have checked my modifications for any breaking changes.

@shamoon shamoon requested a review from a team as a code owner February 13, 2024 16:05
@paperless-ngx-secretary paperless-ngx-secretary bot added frontend non-trivial Requires approval by several team members labels Feb 13, 2024
@github-actions github-actions bot added the bug Bug report or a Bug-fix label Feb 13, 2024
Copy link
Member

@stumpylog stumpylog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure when it might have updated, maybe the reset password? Or the update profile?

@shamoon
Copy link
Member Author

shamoon commented Feb 13, 2024

Yea, I cant find it. DRF is mysterious some times. The workaround is very safe I think, just would be good to track it down to be 100% certain if it's really needed. Anyway, definitely not worth obsessing over...

@shamoon shamoon enabled auto-merge (squash) February 13, 2024 17:19
@shamoon shamoon merged commit d83bbdc into dev Feb 13, 2024
24 checks passed
@shamoon shamoon deleted the fix-5747 branch February 13, 2024 17:25
@shamoon shamoon added this to the v2.5.2 milestone Feb 16, 2024
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns. See our contributing guidelines for more details.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Bug report or a Bug-fix frontend non-trivial Requires approval by several team members
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants