Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add frontend tests to docs #580

Merged
merged 5 commits into from Mar 31, 2022
Merged

Add frontend tests to docs #580

merged 5 commits into from Mar 31, 2022

Conversation

shamoon
Copy link
Member

@shamoon shamoon commented Mar 30, 2022

Proposed change

This PR updates the development documentation with info about code style & tests in the frontend codebase.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other: documentation

Checklist:

  • I have read & agree with the contributing guidelines.
  • If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.
  • If applicable, I have checked that all tests pass, see documentation.
  • I have run all pre-commit hooks, see documentation.
  • I have made corresponding changes to the documentation as needed.
  • I have checked my modifications for any breaking changes.

@shamoon shamoon added documentation Improvements or additions to documentation frontend labels Mar 30, 2022
@shamoon shamoon requested a review from a team March 30, 2022 17:10
@shamoon shamoon self-assigned this Mar 30, 2022
@paperless-ngx-secretary paperless-ngx-secretary bot added the non-trivial Requires approval by several team members label Mar 30, 2022
@coveralls
Copy link

Pull Request Test Coverage Report for Build 2066325640

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.012%

Totals Coverage Status
Change from base Build 2065137810: 0.0%
Covered Lines: 3951
Relevant Lines: 4294

💛 - Coveralls

@shamoon shamoon force-pushed the docs-frontend-tests-style branch 2 times, most recently from ea5c655 to 1e2f9f2 Compare March 30, 2022 17:47
@stumpylog
Copy link
Member

Should this target dev? The front end tests only exist there for the moment?

@shamoon
Copy link
Member Author

shamoon commented Mar 31, 2022

Good point!

@shamoon shamoon changed the base branch from main to dev March 31, 2022 02:05
@shamoon shamoon mentioned this pull request Mar 31, 2022
10 tasks
@shamoon shamoon merged commit 48175d5 into dev Mar 31, 2022
@shamoon shamoon deleted the docs-frontend-tests-style branch March 31, 2022 22:43
@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation frontend non-trivial Requires approval by several team members
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

5 participants