Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: bulk edit objects does not respect global permissions #5888

Merged
merged 2 commits into from Feb 26, 2024

Conversation

shamoon
Copy link
Member

@shamoon shamoon commented Feb 24, 2024

Proposed change

Because this isnt a normal Model endpoint they dont inherently take into account global perms (object permissions are correctly being checked). This fixes both front and backend, of course

Closes #5688 (comment)

Screenshot 2024-02-24 at 3 13 32 PM

Type of change

  • Bug fix: non-breaking change which fixes an issue.
  • New feature / Enhancement: non-breaking change which adds functionality. Please read the important note above.
  • Breaking change: fix or feature that would cause existing functionality to not work as expected.
  • Documentation only.
  • Other. Please explain:

Checklist:

  • I have read & agree with the contributing guidelines.
  • If applicable, I have included testing coverage for new code in this PR, for backend and / or front-end changes.
  • If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.
  • If applicable, I have checked that all tests pass, see documentation.
  • I have run all pre-commit hooks, see documentation.
  • I have made corresponding changes to the documentation as needed.
  • I have checked my modifications for any breaking changes.

@shamoon shamoon added this to the Next Bugfix Release milestone Feb 24, 2024
@shamoon shamoon requested review from a team as code owners February 24, 2024 23:19
@paperless-ngx-secretary paperless-ngx-secretary bot added backend frontend non-trivial Requires approval by several team members labels Feb 24, 2024
@github-actions github-actions bot added the bug Bug report or a Bug-fix label Feb 24, 2024
@shamoon shamoon mentioned this pull request Feb 24, 2024
12 tasks
@shamoon shamoon changed the title Fix issuecomment 1962704295 Fix: bulk edit objects does not respect global permissions Feb 24, 2024
@shamoon shamoon merged commit db0a2eb into dev Feb 26, 2024
31 checks passed
@shamoon shamoon deleted the fix-issuecomment-1962704295 branch February 26, 2024 01:00
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns. See our contributing guidelines for more details.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backend bug Bug report or a Bug-fix frontend non-trivial Requires approval by several team members
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants