Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Correct docker compose check in install script #5917

Merged
merged 2 commits into from Feb 26, 2024

Conversation

ShanSanear
Copy link
Contributor

Proposed change

Adjusting the method of detecting the docker compose plugin to ensure that the script exits early if it is not installed.

Closes #5904

Type of change

  • Bug fix: non-breaking change which fixes an issue.
  • New feature / Enhancement: non-breaking change which adds functionality. Please read the important note above.
  • Breaking change: fix or feature that would cause existing functionality to not work as expected.
  • Documentation only.
  • Other. Please explain:

Checklist:

  • I have read & agree with the contributing guidelines.
  • If applicable, I have included testing coverage for new code in this PR, for backend and / or front-end changes.
  • If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.
  • If applicable, I have checked that all tests pass, see documentation.
  • I have run all pre-commit hooks, see documentation.
  • I have made corresponding changes to the documentation as needed.
  • I have checked my modifications for any breaking changes.

@paperless-ngx-secretary
Copy link

Hello @ShanSanear,

thank you very much for submitting this PR to us!

This is what will happen next:

  1. My robotic colleagues will check your changes to see if they break anything. You can see the progress below.
  2. Once that is finished, human contributors from paperless-ngx review your changes. Since this seems to be a small change, only a single contributor has to review your changes.
  3. Please improve anything that comes up during the review until your pull request gets approved.
  4. Your pull request will be merged into the dev branch. Changes there will be tested further.
  5. Eventually, changes from you and other contributors will be merged into main and a new release will be made.

Please allow up to 7 days for an initial review. We're all very excited about new pull requests but we only do this as a hobby.
If any action will be required by you, please reply within a month.

@github-actions github-actions bot added the bug Bug report or a Bug-fix label Feb 26, 2024
@shamoon shamoon changed the title Fix: Correcting check searching for docker compose plugin (#5904) Fix: Correct docker compose check in install script (#5904) Feb 26, 2024
Copy link

codecov bot commented Feb 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.91%. Comparing base (d2f9b5d) to head (ebd6a69).

❗ Current head ebd6a69 differs from pull request most recent head fa0e028. Consider uploading reports for the commit fa0e028 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #5917      +/-   ##
==========================================
- Coverage   96.92%   96.91%   -0.02%     
==========================================
  Files         405      405              
  Lines       16197    16192       -5     
  Branches     1174     1175       +1     
==========================================
- Hits        15699    15692       -7     
- Misses        498      500       +2     
Flag Coverage Δ
backend 95.59% <ø> (-0.03%) ⬇️
frontend 98.48% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stumpylog stumpylog enabled auto-merge (squash) February 26, 2024 21:17
@stumpylog stumpylog merged commit 86811d0 into paperless-ngx:dev Feb 26, 2024
15 checks passed
@shamoon shamoon changed the title Fix: Correct docker compose check in install script (#5904) Fix: Correct docker compose check in install script Mar 5, 2024
Copy link
Contributor

github-actions bot commented Apr 5, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns. See our contributing guidelines for more details.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Bug report or a Bug-fix deployment small-change
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[BUG] install-paperless-ngx.sh fails to detect lack of "docker compose" on target system
3 participants