Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: refactor base path settings, correct logout redirect #5976

Merged
merged 1 commit into from Mar 3, 2024
Merged

Conversation

shamoon
Copy link
Member

@shamoon shamoon commented Mar 2, 2024

Proposed change

Closes #5974

Type of change

  • Bug fix: non-breaking change which fixes an issue.
  • New feature / Enhancement: non-breaking change which adds functionality. Please read the important note above.
  • Breaking change: fix or feature that would cause existing functionality to not work as expected.
  • Documentation only.
  • Other. Please explain:

Checklist:

  • I have read & agree with the contributing guidelines.
  • If applicable, I have included testing coverage for new code in this PR, for backend and / or front-end changes.
  • If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.
  • If applicable, I have checked that all tests pass, see documentation.
  • I have run all pre-commit hooks, see documentation.
  • I have made corresponding changes to the documentation as needed.
  • I have checked my modifications for any breaking changes.

@shamoon shamoon requested a review from a team as a code owner March 2, 2024 18:40
@paperless-ngx-secretary paperless-ngx-secretary bot added backend non-trivial Requires approval by several team members labels Mar 2, 2024
@shamoon shamoon enabled auto-merge (squash) March 2, 2024 18:40
@shamoon shamoon disabled auto-merge March 2, 2024 18:40
@github-actions github-actions bot added the bug Bug report or a Bug-fix label Mar 2, 2024
@shamoon shamoon enabled auto-merge (squash) March 2, 2024 18:40
@shamoon shamoon changed the title Fix: refactor base path settings Fix: refactor base path settings, correct logout redirect Mar 2, 2024
Copy link

codecov bot commented Mar 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.97%. Comparing base (a698791) to head (bc1e1e1).

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #5976   +/-   ##
=======================================
  Coverage   96.97%   96.97%           
=======================================
  Files         408      408           
  Lines       16246    16249    +3     
  Branches     1179     1178    -1     
=======================================
+ Hits        15754    15757    +3     
  Misses        492      492           
Flag Coverage Δ
backend 95.70% <100.00%> (+<0.01%) ⬆️
frontend 98.48% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shamoon shamoon added this to the Next Release milestone Mar 2, 2024
src/paperless/settings.py Outdated Show resolved Hide resolved
@shamoon shamoon merged commit 23ceb2a into dev Mar 3, 2024
30 checks passed
@shamoon shamoon deleted the fix-5974 branch March 3, 2024 16:22
Copy link
Contributor

github-actions bot commented Apr 3, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns. See our contributing guidelines for more details.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backend bug Bug report or a Bug-fix non-trivial Requires approval by several team members
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[BUG] Incorrect logout redirection with subpath
2 participants